Make :name optional in #page#194
Merged
Merged
Conversation
rohitpaulk
changed the title
This was a bug, introduced in #188
rohitpaulk
force-pushed
the
rohitpaulk/allow-empty-name-in-page
branch
from
April 19, 2019 07:33
4fd02d5 to
b59720a
Compare
Codecov Report
@@ Coverage Diff @@
## master #194 +/- ##
==========================================
- Coverage 99.04% 99.04% -0.01%
==========================================
Files 11 11
Lines 419 418 -1
==========================================
- Hits 415 414 -1
Misses 4 4
Continue to review full report at Codecov.
|
f2prateek
approved these changes
Apr 20, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #192.
This bug was introduced in #188, I misread the Segment spec.