Skip to content

Don't assume that all errors are ConnectionErrors #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rohitpaulk merged 1 commit into from
Apr 2, 2019
Merged

Don't assume that all errors are ConnectionErrors #187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/segment/analytics/request.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ def post(write_key, batch)
if exception
logger.error(exception.message)
exception.backtrace.each { |line| logger.error(line) }
Response.new(-1, "Connection error: #{exception}")
Response.new(-1, exception.to_s)
else
last_response
end
Expand Down
2 changes: 1 addition & 1 deletion spec/segment/analytics/request_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ class Analytics

it 'has a connection error' do
error = subject.post(write_key, batch).error
expect(error).to match(/Connection error/)
expect(error).to match(/Malformed JSON/)
end

it_behaves_like('retried request', 200, 'Malformed JSON ---')
Expand Down