Skip to content

Implement respond_to_missing? instead of respond_to? #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nettofarah merged 1 commit into from
Sep 15, 2017
Merged

Implement respond_to_missing? instead of respond_to? #120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/segment/analytics.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ def method_missing message, *args, &block
end
end

def respond_to? method_name, include_private = false
def respond_to_missing?(method_name, include_private = false)
@client.respond_to?(method_name) || super
end

Expand Down
14 changes: 14 additions & 0 deletions spec/segment/analytics_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,20 @@ class Analytics
end.to_not raise_error
end
end

describe '#respond_to?' do
it 'responds to all public instance methods of Segment::Analytics::Client' do
expect(analytics).to respond_to(*Segment::Analytics::Client.public_instance_methods(false))
end
end

describe '#method' do
Segment::Analytics::Client.public_instance_methods(false).each do |public_method|
it "returns a Method object with '#{public_method}' as argument" do
expect(analytics.method(public_method).class).to eq(Method)
end
end
end
end
end
end