Add log messages for enqueuing messages#108
Closed
daqo wants to merge 2 commits into
Closed
Conversation
added 2 commits
June 29, 2016 15:48
* While running specs in Ruby 2.2.3, three of specs failed. All of them are related to DateTime usages. Converting the time to UTC helps those specs to pass. * Update spec code to use new RSpec syntax
Add logging features to message enqueuing method. When the queue is 70% full, log warns and if it's full log an error, notifying user.
daqo
changed the title
f2prateek
reviewed
Sep 8, 2017
| if is_full | ||
| msg = 'Queue is full, dropping events. ' \ | ||
| 'Please supply :max_queue_size value when initializing the client.' | ||
| logger.error(msg) |
Contributor
There was a problem hiding this comment.
I wonder if this should just be a warn, not error (it is recoverable after all).
Contributor
|
Tracking Internally: https://segment.atlassian.net/browse/LIB-113 |
Collaborator
|
Rebased, #145. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds logging to message enqueuing when queue is full hinting users that events are being dropped.