Conversation
Cover the public API of Data.Pool and Data.Pool.Introspection with a tasty based test suite: * Config validation: newPool rejects invalid TTL, maximum number of resources and stripe counts. * Basic operation: reuse of idle resources, tryTakeResource and tryWithResource on an exhausted pool, destruction of the resource when the action throws, destroyResource, destroyAllResources, distribution of resources across stripes and collection of idle resources after the TTL. * Concurrency: the number of created resources never exceeds the maximum, a blocked thread is woken up by putResource, and a regression test for the fix in 0.5.0.1 where a thread waiting for a resource has to be woken up when resource creation fails in another thread. * Introspection: resource metadata (label, stripe number, creation time) and Immediate/Delayed acquisition. * Stress: concurrent clients with periodic failures on 1 and 4 stripe pools, checking via Data.Pool.Internal that all permits are available, all live resources sit in stripe caches and no thread is queued once the pool is idle again. Synchronization-sensitive tests poll the stripe state through Data.Pool.Internal instead of relying on fixed delays.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cover the public API of Data.Pool and Data.Pool.Introspection with a tasty based test suite:
Config validation: newPool rejects invalid TTL, maximum number of resources and stripe counts.
Basic operation: reuse of idle resources, tryTakeResource and tryWithResource on an exhausted pool, destruction of the resource when the action throws, destroyResource, destroyAllResources, distribution of resources across stripes and collection of idle resources after the TTL.
Concurrency: the number of created resources never exceeds the maximum, a blocked thread is woken up by putResource, and a regression test for the fix in 0.5.0.1 where a thread waiting for a resource has to be woken up when resource creation fails in another thread.
Introspection: resource metadata (label, stripe number, creation time) and Immediate/Delayed acquisition.
Stress: concurrent clients with periodic failures on 1 and 4 stripe pools, checking via Data.Pool.Internal that all permits are available, all live resources sit in stripe caches and no thread is queued once the pool is idle again.
Synchronization-sensitive tests poll the stripe state through Data.Pool.Internal instead of relying on fixed delays.