emit overridden methods for method SymbolInformation - #172
Merged
Conversation
Strum355
changed the title
olafurpg
suggested changes
Apr 20, 2021
olafurpg
left a comment
olafurpg
left a comment
Contributor
There was a problem hiding this comment.
The fix looks good. Can we add unit tests in TargetedSuite that validate that the overrides are defined?
It would be good to check the following cases
- override other method that's defined in the same file
- override other method that's defined outside the file, for example by implementing
AutoCloseable - override interface method
- override abstract class method
- override method with type parameters, example
interface Haha<T> {
void add(T elem);
}
class IntHaha implements Haha<Integer> {
void add(Integer elem) {}
}
olafurpg
suggested changes
Apr 20, 2021
olafurpg
left a comment
olafurpg
left a comment
Contributor
There was a problem hiding this comment.
The new test cases look great. One comment on how to make them a bit less repetitive, otherwise this is ready to merge soon!
| { | ||
| case (count, symbols) => | ||
| assertEquals(count, 1) | ||
| assertEquals(symbols.apply(0), "example/Parent#Haha#add().") |
Contributor
There was a problem hiding this comment.
This is surprisingly difficult to implement if you roll your own semantic analysis
48 tasks
olafurpg
suggested changes
Apr 23, 2021
olafurpg
suggested changes
Apr 26, 2021
olafurpg
approved these changes
Apr 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, if
Ais a subclass of/implementsBandAoverridesB.X, find references onA.Xwould not include the references for theB.Xand vice versa.Addresses https://github.com/sourcegraph/sourcegraph/issues/15699 for lsif-java.
This PR is pending validation of https://github.com/sourcegraph/sourcegraph/pull/20160 with lsif-java output specifically.