fix: improve McpDocsServer concurrency, lifecycle, and error handling#26
Merged
Conversation
- Replace initialized boolean with promise-based lock to prevent race conditions when concurrent requests trigger initialization - Create a new McpServer per request instead of reusing a singleton, preventing transport overwriting under concurrent load - Cache initialization failures so subsequent requests get immediate errors instead of retrying doomed I/O - Fix getStatus() to use SearchProvider.getDocCount() instead of instanceof FlexSearchProvider, preserving the provider abstraction - Sanitize error messages in MCP tool handlers to prevent leaking internal details to clients Closes #15 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
initializedboolean with promise-based lock to prevent race conditions when concurrent requests trigger initializationMcpServerper request instead of reusing a singleton, preventing transport overwriting under concurrent loadgetStatus()to useSearchProvider.getDocCount()instead ofinstanceof FlexSearchProvider, preserving the provider abstractionTest plan
npm run buildpassesnpm run typecheckpassesnpm testpassesCloses #15
🤖 Generated with Claude Code