Skip to content

RFC: Targeting support#166

Open
koenpunt wants to merge 2 commits into
sbugert:masterfrom
koenpunt:targeting
Open

RFC: Targeting support#166
koenpunt wants to merge 2 commits into
sbugert:masterfrom
koenpunt:targeting

Conversation

@koenpunt

@koenpunt koenpunt commented Aug 2, 2017

Copy link
Copy Markdown
Collaborator

I'm not sure if using nested props is the right approach, so if you have any suggestions, please let me know!

Maybe an imperative API in the form of passing arguments to loadBanner is more suitable?

Edit: or maybe just a "standalone" API to set these properties, as they are not expected to change very often in a session (I presume).

This would be a fix for #98, so maybe @vseprav wants to chime in as well?

@koenpunt koenpunt mentioned this pull request Aug 2, 2017
9 tasks
@koenpunt koenpunt requested a review from alvaromb August 2, 2017 22:23
@koenpunt koenpunt force-pushed the next branch 4 times, most recently from e864ac4 to 6b7e96c Compare September 28, 2017 13:36
@koenpunt koenpunt changed the title Proposal: Targeting support RFC: Targeting support Sep 28, 2017
@koenpunt koenpunt changed the base branch from next to master October 3, 2017 20:22
@kaanduraa

Copy link
Copy Markdown

Any updates on Android targeting ?

@koenpunt

koenpunt commented Oct 4, 2017

Copy link
Copy Markdown
Collaborator Author

Any updates on Android targeting ?

I first want to settle the API before starting development for Android.

@kaanduraa

Copy link
Copy Markdown

Thanks for the reply, I need targeting in my project very badly because my users are the same type. Perhaps I can help you out?

@koenpunt koenpunt mentioned this pull request Oct 4, 2017
@engvik

engvik commented Nov 8, 2017

Copy link
Copy Markdown

Hi! Any progress on this? Would love to see this happening 😄

And let me know if there's anything I can help with in the Android part.

@marudy

marudy commented Dec 30, 2017

Copy link
Copy Markdown

Hello!

Happy holidays and a happy fruitful new year to everyone!

Any progress regarding this? I would also like to see this happening and implement in my Android game 😃

@koenpunt koenpunt mentioned this pull request Mar 10, 2018
@davidepalazzo

Copy link
Copy Markdown

Hey guys,

Just wondering is there any update on this feature?

Thanks!

@shukerullah

Copy link
Copy Markdown

Any update on this?

@Bitterballs

Copy link
Copy Markdown

Is there a update already?

@chsjr1996

Copy link
Copy Markdown

Hey people, i made this pull request to allow targeting in Android too.

#469

I'm not sure if using nested prop is the right approach, so if you have any suggestions, please let me know!
@KVinS

KVinS commented Aug 2, 2020

Copy link
Copy Markdown

@koenpunt hello.
In fact, now all applications containing the plugin violate the law due to the use of personal data.
Maybe it is possible to do at least support for the npa flag?
How did ammarahm-ed do it

2020-08-02_04-12-45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants