Cpp port performance improvements - #91
Merged
Merged
Conversation
and remove vec copies that were needed before
Extract error correction computation into a separate non-generic function to avoid code duplication across different types.
Collaborator
|
Both this and #89 are looking good, though I haven't had a chance to fully review. Likely I'll roll them both up into 0.9.2. |
hschimke
approved these changes
Jul 22, 2026
hschimke
left a comment
hschimke
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to merge, planned for next release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some commits all relating to optimizing away copies of Vecs in the cpp_port code.
Measured to be around 10% faster on large QR codes.