fix: allow use in bundlers - #10
Closed
achingbrain wants to merge 1 commit into
Closed
Conversation
We can't use the `**` operator as right now it gets transpiled to `Math.pow` which only takes Numbers. Similarly, trying to avoid referencing node globals to get a `Buffer` instance causes similar problems now that bundlers don't tend to come with node polyfills any more. Swaps the use of `**` for the BigInt literal result of the calculation and uses the `Buffer` module to ensure compatibility. Fixes #7 Fixes #8 Please publish with a `main` field to also fix #9.
28 tasks
Contributor
Author
|
These are the changes I have to make to get the examples passing in ipfs/js-ipfs#3550 |
rvagg
reviewed
Mar 26, 2021
| 2 ** 16, | ||
| 2 ** 32, | ||
| // BigInt(2) ** BigInt(64) gets transpiled to Math.pow(BigInt(2), BigInt(64)) so use the literal value | ||
| 18446744073709551616n |
Owner
There was a problem hiding this comment.
I can't use literals though, I started off with all literals but it breaks with some version of something, I can't recall which, but literals are a bit too new compared to the constructor, BigInt('18446744073709551616') might be acceptable though.
Contributor
Author
|
Superseded by #11 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can't use the
**operator as right now it gets transpiled toMath.powwhich only takes Numbers.Similarly, trying to avoid referencing node globals to get a
Bufferinstance causes similar problems now that bundlers don't tend to come with node polyfills any more.Swaps the use of
**for the BigInt literal result of the calculation and uses theBuffermodule to ensure compatibility.Fixes #7
Fixes #8
Please publish with a
mainfield that points to a cjs version of this module to also fix #9.