test(download): serialize tests with proxy-sensitive URLs#4372
Conversation
|
Without this change, I could pretty reliably induce this race by narrowing the testsuite, so they're more likely to run in parallel. Note that the |
|
@cuviper Thanks a lot for your investigation! This does look like one of the reasons why Rustup's CI is not as stable as expected. I'll have a look at your patch real soon :) |
There was a problem hiding this comment.
LGTM!
Nit: Before merging, it'd be probably better to change the commit message to "all download tests" instead of just "all tests"... I know by "proxy-sensitive URLs" it implies download tests, but it looks a bit misleading at the first glance 💦 Many thanks in advance I decided to do that myself, never mind :)
There was already a guard for tests that *set* a proxy variable in the environment, but this is also relevant for tests that would implicitly read those variables while downloading a local `serve_file` URL.
The upstream fix (rust-lang/rustup#4372) has been merged and is included in rustup 1.29.0, which is already available in the locked nixpkgs. The skip-test workaround for NixOS/nixpkgs#470496 is no longer needed; the package builds cleanly and is fetched from cache.nixos.org.
There was already a guard for tests that set a proxy variable in the
environment, but this is also relevant for tests that would implicitly
read those variables while downloading a local
serve_fileURL.