Fix clippy error#3133
Conversation
0xPoe
left a comment
0xPoe
left a comment
There was a problem hiding this comment.
Thanks a lot!
If you can separate your changes with the lint name by commit, it would be great.
chansuke
force-pushed
the
hotfix/fix-clippy
branch
from
86e1a6d to
ad5193b
Compare
|
@hi-rustin I have updated the commit log with clippy name. Some of the messages are duplicated because |
0xPoe
left a comment
0xPoe
left a comment
There was a problem hiding this comment.
Could you please squash your first and third commits? I think they are from the same lint.
rest LGTM. Thanks again!
| @@ -1,5 +1,6 @@ | |||
| //! Easy file downloading | |||
| #![deny(rust_2018_idioms)] | |||
| #![allow(clippy::type_complexity)] | |||
There was a problem hiding this comment.
I prefer to warn it. We may find a better way to fix it in the future.
There was a problem hiding this comment.
@chansuke Could you please remove this? Then we can merge this PR.
|
Also, could you please rebase your base branch? It seems you still using the 2022 master branch. |
chansuke
force-pushed
the
hotfix/fix-clippy
branch
from
ad5193b to
4a44765
Compare
|
Sorry for many time. I will fix this tonight(JST) |
chansuke
force-pushed
the
hotfix/fix-clippy
branch
from
4a44765 to
2890305
Compare
0xPoe
left a comment
0xPoe
left a comment
There was a problem hiding this comment.
Thanks again. I'm sorry for this back-and-forth discussion. I should have said it all at once.
Because this is a nit change. I'll push it directly.
| } | ||
| } | ||
|
|
||
| type EventResult<'a> = &'a dyn Fn(Event<'_>) -> Result<()>; |
There was a problem hiding this comment.
We had some discussions on this change before: #3096 (comment)
| type EventResult<'a> = &'a dyn Fn(Event<'_>) -> Result<()>; | |
| type DownloadCallback<'a> = &'a dyn Fn(Event<'_>) -> Result<()>; |
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
|
No problem. Thank you so much for your help. |
2 participants
Fix clippy error.