Merge rustup's crates#1704
Merged
Merged
Conversation
dwijnand
force-pushed
the
merge-crates
branch
2 times, most recently
from
bda4b07 to
efc89e1
Compare
Contributor
|
☔ The latest upstream changes (presumably #1682) made this pull request unmergeable. Please resolve the merge conflicts. |
Contributor
Author
kinnison
approved these changes
Mar 14, 2019
kinnison
left a comment
kinnison
left a comment
Contributor
There was a problem hiding this comment.
Pretty much spot on what I was expecting.
Two comments, but if they don't end up implying changes, then 👍
Contributor
|
☔ The latest upstream changes (presumably #1711) made this pull request unmergeable. Please resolve the merge conflicts. |
kinnison
approved these changes
Mar 15, 2019
This was referenced Mar 15, 2019
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1644