Skip to content

Remove visible path calculation from allowed deprecation lint - #89395

Merged
bors merged 1 commit into
rust-lang:masterfrom
In-line:remove_visible_path_from_allowed_deprecated_lint
Oct 1, 2021
Merged

Remove visible path calculation from allowed deprecation lint#89395
bors merged 1 commit into
rust-lang:masterfrom
In-line:remove_visible_path_from_allowed_deprecated_lint

Conversation

@In-line

@In-line In-line commented Sep 30, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@rust-highfive

rust-highfive commented Sep 30, 2021

Copy link
Copy Markdown
Contributor

r? @davidtwco

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 30, 2021
@In-line

In-line commented Sep 30, 2021

Copy link
Copy Markdown
Contributor Author

Please kindly do a perf run

@davidtwco

davidtwco commented Sep 30, 2021

Copy link
Copy Markdown
Member

@bors try @rust-timer queue

@rust-timer

rust-timer commented Sep 30, 2021

Copy link
Copy Markdown
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 30, 2021
@bors

bors commented Sep 30, 2021

Copy link
Copy Markdown
Collaborator

⌛ Trying commit d98ac57 with merge d9adfdc04c6c9666a80f3c6a09cd3a40cabc2b44...

@In-line

In-line commented Sep 30, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Related #87349 #89120

@bors

bors commented Sep 30, 2021

Copy link
Copy Markdown
Collaborator

☀️ Try build successful - checks-actions
Build commit: d9adfdc04c6c9666a80f3c6a09cd3a40cabc2b44 (d9adfdc04c6c9666a80f3c6a09cd3a40cabc2b44)

@rust-timer

rust-timer commented Sep 30, 2021

Copy link
Copy Markdown
Collaborator

Queued d9adfdc04c6c9666a80f3c6a09cd3a40cabc2b44 with parent 69c1c6a, future comparison URL.

@rust-timer

rust-timer commented Sep 30, 2021

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (d9adfdc04c6c9666a80f3c6a09cd3a40cabc2b44): comparison url.

Summary: This change led to very large relevant improvements 🎉 in compiler performance.

  • Very large improvement in instruction counts (up to -10.9% on incr-patched: minor change builds of tokio-webpush-simple)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 30, 2021
@jyn514 jyn514 added A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. I-compiletime Issue: Problems and improvements with respect to compile times. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 30, 2021
@jyn514

jyn514 commented Sep 30, 2021

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Sep 30, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit d98ac57 has been approved by jyn514

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 30, 2021
@bors

bors commented Sep 30, 2021

Copy link
Copy Markdown
Collaborator

⌛ Testing commit d98ac57 with merge 7d69c5859dc31a6dc94cf852628f4b2c5af92dd2...

@jyn514 jyn514 added the relnotes-perf Performance improvements that should be mentioned in the release notes. label Sep 30, 2021
@bors

bors commented Sep 30, 2021

Copy link
Copy Markdown
Collaborator

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 30, 2021
@rust-log-analyzer

rust-log-analyzer commented Sep 30, 2021

Copy link
Copy Markdown
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@jyn514

jyn514 commented Sep 30, 2021

Copy link
Copy Markdown
Member

Timed out on apple without logs.

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 30, 2021
@bors

bors commented Oct 1, 2021

Copy link
Copy Markdown
Collaborator

⌛ Testing commit d98ac57 with merge 4e4942d...

@bors

bors commented Oct 1, 2021

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: jyn514
Pushing 4e4942d to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 1, 2021
@bors
bors merged commit 4e4942d into rust-lang:master Oct 1, 2021
@rustbot rustbot added this to the 1.57.0 milestone Oct 1, 2021
@In-line
In-line deleted the remove_visible_path_from_allowed_deprecated_lint branch October 1, 2021 09:04
@In-line In-line mentioned this pull request Oct 1, 2021
Closed
@rust-timer

rust-timer commented Oct 1, 2021

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (4e4942d): comparison url.

Summary: This change led to very large relevant improvements 🎉 in compiler performance.

  • Very large improvement in instruction counts (up to -10.9% on incr-patched: minor change builds of tokio-webpush-simple)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@davidtwco davidtwco

Labels

A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. I-compiletime Issue: Problems and improvements with respect to compile times. merged-by-bors This PR was explicitly merged by bors. relnotes-perf Performance improvements that should be mentioned in the release notes. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.57.0

Development

Successfully merging this pull request may close these issues.

8 participants

@In-line @rust-highfive @davidtwco @rust-timer @bors @jyn514 @rust-log-analyzer @rustbot