Skip to content

Keep stdout open in limit_vector_count test#75228

Merged
bors merged 1 commit into
rust-lang:masterfrom
tmiasko:keep-stdout-open
Aug 6, 2020
Merged

Keep stdout open in limit_vector_count test#75228
bors merged 1 commit into
rust-lang:masterfrom
tmiasko:keep-stdout-open

Conversation

@tmiasko

@tmiasko tmiasko commented Aug 6, 2020

Copy link
Copy Markdown
Contributor

No description provided.

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @kennytm

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 6, 2020
@tmiasko

tmiasko commented Aug 6, 2020

Copy link
Copy Markdown
Contributor Author

Unintentional close of stdout caused issues on CI in #75121, #75206, #75215, and #74888, so this should be prioritized.

@ecstatic-morse

Copy link
Copy Markdown
Contributor

@bors r+ p=5

@bors

bors commented Aug 6, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 888bc07 has been approved by ecstatic-morse

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 6, 2020
@bors

bors commented Aug 6, 2020

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 888bc07 with merge 71f8d0c...

@ecstatic-morse

ecstatic-morse commented Aug 6, 2020

Copy link
Copy Markdown
Contributor

cc @adamreichold #75005

Good find by the way.

@adamreichold

adamreichold commented Aug 6, 2020

Copy link
Copy Markdown
Contributor

cc @adamreichold #75005

Good find by the way.

I am sorry for the issues and annoyance this has caused. With hindsight, a temporary file would probably have a been better choice. :-(

@bors

bors commented Aug 6, 2020

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions, checks-azure
Approved by: ecstatic-morse
Pushing 71f8d0c to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 6, 2020
@bors bors merged commit 71f8d0c into rust-lang:master Aug 6, 2020
@tmiasko tmiasko deleted the keep-stdout-open branch August 7, 2020 04:56
@cuviper cuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants