2018 edition - confusing error message when declaring unnamed parameters #56584
Merged
Conversation
Contributor
|
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
Contributor
This commit adds a note providing context for the change to argument names being required in the 2018 edition for trait methods.
This commit emits a suggestion for adding an underscore binding to arguments in trait methods that previously did not have a argument name specified.
davidtwco
force-pushed
the
issue-53990
branch
from
9d1f89e to
7fcf31b
Compare
Member
Author
Ah, good point @Nemo157. I've updated the messages. |
nikomatsakis
approved these changes
Dec 11, 2018
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit 7fcf31b has been approved by |
bors
added
S-waiting-on-bors
Collaborator
|
⌛ Testing commit 7fcf31b with merge e8c8d274b0b611a5d4711af6095d477729436e30... |
Collaborator
|
💔 Test failed - status-appveyor |
bors
added
S-waiting-on-review
Contributor
|
Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem. Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Member
|
@bors: retry
|
bors
added
S-waiting-on-bors
Collaborator
bors
added a commit
that referenced
this pull request
Dec 15, 2018
2018 edition - confusing error message when declaring unnamed parameters Fixes #53990. This PR adds a note providing context for the change to argument names being required in the 2018 edition for trait methods and a suggestion for the fix.
Collaborator
|
☀️ Test successful - status-appveyor, status-travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #53990.
This PR adds a note providing context for the change to argument
names being required in the 2018 edition for trait methods and a
suggestion for the fix.