rustc_mir: always run the inlining pass.#48602
Closed
eddyb wants to merge 4 commits into
Closed
Conversation
Contributor
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Contributor
Author
|
@bors try |
Collaborator
bors
added a commit
that referenced
this pull request
Feb 28, 2018
rustc_mir: always run the inlining pass. **DO NOT MERGE**: there are still issues around debuginfo and maybe even misoptimizations. As suggested by @pcwalton, maybe it's time to test the overhead / wins from turning MIR inlining on.
Collaborator
|
💔 Test failed - status-travis |
bors
added
S-waiting-on-author
Contributor
Author
Maybe the specialization bugs weren't fixed, huh. |
Contributor
Author
|
@bors try |
Collaborator
bors
added a commit
that referenced
this pull request
Feb 28, 2018
rustc_mir: always run the inlining pass. **DO NOT MERGE**: there are still issues around debuginfo and maybe even misoptimizations. As suggested by @pcwalton, maybe it's time to test the overhead / wins from turning MIR inlining on.
Collaborator
|
💔 Test failed - status-travis |
Contributor
|
@eddyb let me know when there is a need for me to review |
Collaborator
|
☔ The latest upstream changes (presumably #48586) made this pull request unmergeable. Please resolve the merge conflicts. |
Member
|
Ping from triage @eddyb! It has been a while since you updated this PR. |
Member
|
@eddyb closing for inactivity, feel free to reopen the PR when you have some spare time to finish this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE: there are still issues around debuginfo and maybe even misoptimizations.
As suggested by @pcwalton, maybe it's time to test the overhead / wins from turning MIR inlining on.