rustc: Further tweak linkage in ThinLTO#46549
Merged
Merged
Conversation
Contributor
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
Member
Author
kennytm
added
the
S-waiting-on-review
kennytm
reviewed
Dec 7, 2017
Member
There was a problem hiding this comment.
Needs // min-llvm-version 4.0.
[00:48:34] ---- [run-pass] run-pass/thinlto/weak-works.rs stdout ----
[00:48:34]
[00:48:34] error: compilation failed!
[00:48:34] status: exit code: 101
[00:48:34] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/run-pass/thinlto/weak-works.rs" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass" "--target=x86_64-unknown-linux-gnu" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass/thinlto/weak-works.stage2-x86_64-unknown-linux-gnu" "-Crpath" "-O" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-C" "codegen-units=8" "-Z" "thinlto" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass/thinlto/weak-works.stage2-x86_64-unknown-linux-gnu.aux"
[00:48:34] stdout:
[00:48:34] ------------------------------------------
[00:48:34]
[00:48:34] ------------------------------------------
[00:48:34] stderr:
[00:48:34] ------------------------------------------
[00:48:34] error: this compiler's LLVM does not support ThinLTO
Member
|
Thank you, Alex! r=me with the test fixed. |
kennytm
added
S-waiting-on-author
In rust-lang#46382 the logic around linkage preservation with ThinLTO ws tweaked but the loop that registered all otherwise exported GUID values as "don't internalize me please" was erroneously too conservative and only asking "external" linkage items to not be internalized. Instead we actually want the inversion of that condition, everything *without* "local" linkage to be internalized. This commit updates the condition there, adds a test, and... Closes rust-lang#46543
alexcrichton
force-pushed
the
thinlto-weak
branch
from
cb1ca56 to
17fb43b
Compare
Member
Author
|
@bors: r=michaelwoerister |
Collaborator
|
📌 Commit 17fb43b has been approved by |
kennytm
added
S-waiting-on-bors
Collaborator
bors
added a commit
that referenced
this pull request
Dec 8, 2017
rustc: Further tweak linkage in ThinLTO In #46382 the logic around linkage preservation with ThinLTO ws tweaked but the loop that registered all otherwise exported GUID values as "don't internalize me please" was erroneously too conservative and only asking "external" linkage items to not be internalized. Instead we actually want the inversion of that condition, everything *without* "local" linkage to be internalized. This commit updates the condition there, adds a test, and... Closes #46543
Collaborator
|
☀️ Test successful - status-appveyor, status-travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #46382 the logic around linkage preservation with ThinLTO ws tweaked but the
loop that registered all otherwise exported GUID values as "don't internalize
me please" was erroneously too conservative and only asking "external" linkage
items to not be internalized. Instead we actually want the inversion of that
condition, everything without "local" linkage to be internalized.
This commit updates the condition there, adds a test, and...
Closes #46543