rustc_mir: promote references of statics from other statics.#46524
Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
There was a problem hiding this comment.
nit: I would prefer that this codepath be shared with the shuffle index code into a fn can_promote
|
r=me with nit fixed |
There was a problem hiding this comment.
Why only in other statics? Couldn't references to statics always be promoted
There was a problem hiding this comment.
It's just what we already allow. Must avoid letting in more until miri is in use.
|
@arielb1 The Travis failure suggests MIR borrowck doesn't handle this yet. Does it need your PR? |
kennytm
added
the
S-waiting-on-review
|
Maybe. I don't remember the state of MIR borrowck before this PR. I suppose we can wait - this doesn't block me. |
kennytm
added
S-blocked
|
Marking as blocked by #46268. |
eddyb
removed
the
S-blocked
|
@bors r=arielb1 |
|
📌 Commit 292c6ac has been approved by |
rustc_mir: promote references of statics from other statics. Fixes #46522 by also allowing `STATIC_REF` in MIR const-qualification, not just AST rvalue promotion.
|
☀️ Test successful - status-appveyor, status-travis |
7 participants
Fixes #46522 by also allowing
STATIC_REFin MIR const-qualification, not just AST rvalue promotion.