Skip to content

DO NOT MERGE: Enable full backtraces#46222

Closed
Zoxc wants to merge 1 commit into
rust-lang:masterfrom
Zoxc:test-with-backtraces
Closed

DO NOT MERGE: Enable full backtraces#46222
Zoxc wants to merge 1 commit into
rust-lang:masterfrom
Zoxc:test-with-backtraces

Conversation

@Zoxc

@Zoxc Zoxc commented Nov 23, 2017

Copy link
Copy Markdown
Contributor

No description provided.

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@Zoxc

Zoxc commented Nov 23, 2017

Copy link
Copy Markdown
Contributor Author

@bors try

@bors

bors commented Nov 23, 2017

Copy link
Copy Markdown
Collaborator

⌛ Trying commit 1f1c060 with merge 685bdd4...

bors added a commit that referenced this pull request Nov 23, 2017
DO NOT MERGE: Enable full backtraces
@kennytm kennytm added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Nov 23, 2017
@kennytm

kennytm commented Nov 23, 2017

Copy link
Copy Markdown
Member

The last time I tried (#45693), while the CI duration is more or less the same for Linux, macOS slowed down to close to the 3 hour limit. So I don't think this can be unconditionally enabled.

@bors

bors commented Nov 23, 2017

Copy link
Copy Markdown
Collaborator

☀️ Test successful - status-travis
State: approved= try=True

@alexcrichton

Copy link
Copy Markdown
Member

What's the rationale for this? (no PR description, no documentation...) Why full instead of 1? Why set unconditionally in bootstrap.py with no option to turn it off?

@Zoxc

Zoxc commented Nov 24, 2017

Copy link
Copy Markdown
Contributor Author

I saw a heap corruption on Windows with backtraces enabled, so I wanted to see if that happened on CI too, but I guess try is Linux only and doesn't run tests now.

@kennytm

kennytm commented Nov 24, 2017

Copy link
Copy Markdown
Member

@Zoxc Is there an issue for this?

@Zoxc

Zoxc commented Nov 24, 2017

Copy link
Copy Markdown
Contributor Author

@kennytm There is one now: #46243

@Zoxc Zoxc closed this Nov 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants