refactor if so that the "then type" is an expression#40391
Closed
nikomatsakis wants to merge 2 commits into
Closed
refactor if so that the "then type" is an expression#40391nikomatsakis wants to merge 2 commits into
nikomatsakis wants to merge 2 commits into
Conversation
eddyb
reviewed
Mar 9, 2017
Contributor
There was a problem hiding this comment.
This comment should be updated.
eddyb
approved these changes
Mar 9, 2017
eddyb
left a comment
eddyb
left a comment
Contributor
There was a problem hiding this comment.
r=me with the comment and the title ("then type") fixed
nikomatsakis
force-pushed
the
refactor-if
branch
from
576fdff to
002950b
Compare
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit 002950b has been approved by |
Contributor
|
Travis failed: |
Contributor
|
@bors r- |
Collaborator
|
☔ The latest upstream changes (presumably #40693) made this pull request unmergeable. Please resolve the merge conflicts. |
Contributor
Author
|
closing this PR; I'll roll the change into #40224 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a useful refactoring that I want for other branches.
r? @eddyb