Fix TryFrom for i128/u128#39408
Merged
Merged
Conversation
Contributor
|
r? @sfackler (rust_highfive has picked a reviewer for you, use r? to override) |
Member
|
@bors r+ |
Collaborator
|
📌 Commit 8fad6cf has been approved by |
Collaborator
|
⌛ Testing commit 8fad6cf with merge e92e317... |
Collaborator
|
💔 Test failed - status-travis |
Collaborator
|
☔ The latest upstream changes (presumably #39463) made this pull request unmergeable. Please resolve the merge conflicts. |
Member
|
Needs a rebase |
Another case of `as` cast silent truncation being error prone. This also adds a few missing TryFrom tests to libcoretest.
ollie27
force-pushed
the
i128_try_from
branch
from
8fad6cf to
a2de6e2
Compare
Contributor
Author
|
I've rebased and also removed the |
Member
|
@bors: r+ Thanks! |
Collaborator
|
📌 Commit a2de6e2 has been approved by |
Collaborator
Collaborator
|
☀️ Test successful - status-appveyor, status-travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another case of
ascast silent truncation being error prone.This also adds a few missing TryFrom tests to libcoretest.
cc #33417
cc #35118