mk: Don't consider LLVM done until it's done#34563
Conversation
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ p=1 |
|
📌 Commit f94b2f2 has been approved by |
|
⌛ Testing commit f94b2f2 with merge 98f7ce9... |
|
💔 Test failed - auto-linux-64-opt-mir |
Currently if an LLVM build is interrupted *after* it creates the llvm-config binary but before it's done it puts us in an inconsistent state where we think LLVM is compiled but it's not actually. This tweaks our logic to only consider LLVM done building once it's actually done building. This should hopefully alleviate problems on the bots where if we interrupt at the wrong time it doesn't corrupt the build directory.
|
@bors: r=brson |
|
📌 Commit 9e2bd92 has been approved by |
|
⌛ Testing commit 9e2bd92 with merge 949f893... |
|
⛄ The build was interrupted to prioritize another pull request. |
mk: Don't consider LLVM done until it's done Currently if an LLVM build is interrupted *after* it creates the llvm-config binary but before it's done it puts us in an inconsistent state where we think LLVM is compiled but it's not actually. This tweaks our logic to only consider LLVM done building once it's actually done building. This should hopefully alleviate problems on the bots where if we interrupt at the wrong time it doesn't corrupt the build directory.
|
💔 Test failed - auto-linux-64-x-android-t |
|
@bors: retry On Fri, Jul 1, 2016 at 1:47 AM, bors notifications@github.com wrote:
|
4 participants
Currently if an LLVM build is interrupted after it creates the llvm-config
binary but before it's done it puts us in an inconsistent state where we think
LLVM is compiled but it's not actually. This tweaks our logic to only consider
LLVM done building once it's actually done building.
This should hopefully alleviate problems on the bots where if we interrupt at
the wrong time it doesn't corrupt the build directory.