Skip to content

Document block doc comments better#29819

Merged
bors merged 1 commit into
rust-lang:masterfrom
mdinger:block-comments
Nov 14, 2015
Merged

Document block doc comments better#29819
bors merged 1 commit into
rust-lang:masterfrom
mdinger:block-comments

Conversation

@mdinger

@mdinger mdinger commented Nov 13, 2015

Copy link
Copy Markdown
Contributor

These really aren't documented well at all. The fact that doc comments end on a */ is really weird. I'm not sure if this is a mistake or not though.

None of the block comments are even mentioned in the book nightly. Probably should be fixed.

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@steveklabnik

Copy link
Copy Markdown
Contributor

The block comments aren't mentioned in the book because it's not idiomatic to use them.

Thanks for the patch! Being more explicit about the endings seems good :)

@steveklabnik

Copy link
Copy Markdown
Contributor

@bors: r+ rollup

@bors

bors commented Nov 13, 2015

Copy link
Copy Markdown
Collaborator

📌 Commit 4e74f9b has been approved by steveklabnik

@bors

bors commented Nov 14, 2015

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 4e74f9b with merge 968e8bf...

bors added a commit that referenced this pull request Nov 14, 2015
These really aren't documented well at all. The fact that doc comments end on a `*/` is really weird. I'm not sure if this is a mistake or not though.

None of the block comments are even mentioned in the [book nightly](http://doc.rust-lang.org/nightly/book/comments.html). Probably should be fixed.
@bors bors merged commit 4e74f9b into rust-lang:master Nov 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants