Skip to content

Add defaulted impls for Send and Sync - #23211

Merged
bors merged 4 commits into
rust-lang:masterfrom
flaper87:oibit-send-and-friends
Mar 24, 2015
Merged

Add defaulted impls for Send and Sync#23211
bors merged 4 commits into
rust-lang:masterfrom
flaper87:oibit-send-and-friends

Conversation

@flaper87

@flaper87 flaper87 commented Mar 9, 2015

Copy link
Copy Markdown
Contributor

@bors

bors commented Mar 10, 2015

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #23038) made this pull request unmergeable. Please resolve the merge conflicts.

@nikomatsakis

Copy link
Copy Markdown
Contributor

@flaper87 rebase?

@flaper87
flaper87 force-pushed the oibit-send-and-friends branch from 2c1d7bd to bcc3955 Compare March 10, 2015 13:00
@flaper87

Copy link
Copy Markdown
Contributor Author

@nikomatsakis r?

Comment thread src/libcore/marker.rs Outdated

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be unsafe

@nikomatsakis

Copy link
Copy Markdown
Contributor

r+ modulo suggested refactoring

@flaper87
flaper87 force-pushed the oibit-send-and-friends branch from 9135cfa to cc56e71 Compare March 18, 2015 14:55
@nikomatsakis

Copy link
Copy Markdown
Contributor

@bors r+ cc56e71

@bors

bors commented Mar 18, 2015

Copy link
Copy Markdown
Collaborator

⌛ Testing commit cc56e71 with merge 2c87f00...

@bors

bors commented Mar 18, 2015

Copy link
Copy Markdown
Collaborator

⛄ The build was interrupted to prioritize another pull request.

@bors

bors commented Mar 18, 2015

Copy link
Copy Markdown
Collaborator

⌛ Testing commit cc56e71 with merge aedaaee...

@bors

bors commented Mar 18, 2015

Copy link
Copy Markdown
Collaborator

💔 Test failed - auto-mac-64-opt

@Manishearth

Copy link
Copy Markdown
Member
foo.rs:16:5: 16:23 error: default trait implementations are experimental and possibly buggy
foo.rs:16     impl Bar for .. {}
              ^~~~~~~~~~~~~~~~~~
foo.rs:16:23: 16:23 help: add #![feature(optin_builtin_traits)] to the crate attributes to enable
error: aborting due to previous error
make[1]: *** [all] Error 101

@flaper87
flaper87 force-pushed the oibit-send-and-friends branch from cc56e71 to f54a38e Compare March 20, 2015 15:46
@flaper87
flaper87 force-pushed the oibit-send-and-friends branch from f54a38e to 04d5772 Compare March 20, 2015 15:48
@flaper87

Copy link
Copy Markdown
Contributor Author

@bors: r=nikomatsakis 04d5772

@nikomatsakis

Copy link
Copy Markdown
Contributor

@bors r+ 04d5772

@bors

bors commented Mar 23, 2015

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 04d5772 with merge 3549eaf...

@bors

bors commented Mar 23, 2015

Copy link
Copy Markdown
Collaborator

💔 Test failed - auto-mac-32-opt

@alexcrichton

Copy link
Copy Markdown
Member

@bors: retry

On Mon, Mar 23, 2015 at 6:11 AM, bors notifications@github.com wrote:

[image: 💔] Test failed - auto-mac-32-opt
http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/4206


Reply to this email directly or view it on GitHub
#23211 (comment).

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Mar 23, 2015
@bors

bors commented Mar 24, 2015

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 04d5772 with merge 40b654d...

@bors

bors commented Mar 24, 2015

Copy link
Copy Markdown
Collaborator

⛄ The build was interrupted to prioritize another pull request.

@bors
bors merged commit 04d5772 into rust-lang:master Mar 24, 2015
@fmease fmease mentioned this pull request Apr 12, 2026
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

impl Trait for .. {} does not require a feature gate

5 participants