Skip to content

Rollup of 16 pull requests - #161356

Closed
JonathanBrouwer wants to merge 46 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-LILEZ1T
Closed

Rollup of 16 pull requests#161356
JonathanBrouwer wants to merge 46 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-LILEZ1T

Conversation

@JonathanBrouwer

Copy link
Copy Markdown
Member

Successful merges:

r? @ghost

Create a similar rollup

mejrs and others added 30 commits August 5, 2026 19:09
This patch implements Rust's equivalent of Clang's function pointer type
discriminator computation used in pointer authentication. Compatibility
with Clang is a primary goal. The discriminator produced for a given
external "C" function type must match the value computed by Clang so
that function pointers can be exchanged safely between Rust and C code
while preserving pointer authentication semantics.

The implementation mirrors Clang's behavior in
`ASTContext::encodeTypeForFunctionPointerAuth`, ensuring that identical
C-compatible function types produce identical discriminators. See:
<https://clang.llvm.org/doxygen/ASTContext_8cpp.html#abb1375e068e807917527842d05cadea3>.
To `QuerySystem`, next to `query_vtables`. It's a better spot for it.
`MCOptions` is the name of the variable commonly used for instances of
`MCTargetOptions`. Use the proper type name instead.
Items with implicit `pub(self)` visibility in the crate root are effectively
`pub(crate)`, which causes friction when trying to move them elsewhere.
This intermediate commit helps to preserve line history.
…parent]` is applied

Co-authored-by: León Orell Valerian Liehr <me@fmease.dev>
This commit moves the eight cache fields in `GlobalCtxt` into a single
type, just to provide some logical grouping and to reduce the number of
fields within `GlobalCtxt`.
It makes sense next to `QuerySystem::side_effects`, and this enables the
use of `DepNodeIndex` for the values instead of the type-erased `u32`.
@rustbot rustbot added A-bootstrap-stamp Area: bootstrap stamp logic A-CI Area: Our Github Actions CI A-meta Area: Issues & PRs about the rust-lang/rust repository itself A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) A-testsuite Area: The testsuite used to check the correctness of rustc PG-exploit-mitigations Project group: Exploit mitigations S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Aug 19, 2026
@JonathanBrouwer

Copy link
Copy Markdown
Member Author

@bors r+ p=5

@rust-bors

rust-bors Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 50154f6 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 19, 2026
@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Aug 19, 2026
…uwer

Rollup of 16 pull requests

Successful merges:

 - #159071 ([PAC] Encoder and hash (1/8))
 - #161277 (bootstrap: Move all non-module items out of the crate root)
 - #161332 (Some `GlobalCtxt`/`Session` cleanups)
 - #161344 (Update the `rustc-perf` submodule)
 - #150931 (rustdoc: Always document `#[repr(transparent)]` if `#[rustc_pub_transparent]` is applied)
 - #160582 (Add `remove hidden_glob_reexports item breaks downstream` test)
 - #160876 (remove unwrap from write_mir_fn_graphviz)
 - #160927 (Enhance EII UI tests)
 - #161070 (fix arm homogeneous aggregate ABI)
 - #161236 (Download auto jobs in citool in parallel)
 - #161254 (Reserve capacity for 3% anon nodes)
 - #161283 (Tighten the language used for documenting `TargetOptions::llvm_abiname`)
 - #161291 (Rename `ProjectionPredicate` and `TraitPredicate`)
 - #161299 (Remove a bunch of unnecessary explicit lifetimes)
 - #161307 (make ARM maintainers pingable)
 - #161308 (Add regression test for rustc diagnostic to recognize variables in match guards)
@rust-bors rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 19, 2026
@rust-bors

rust-bors Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

💔 Test for b36ff5f failed: CI. Failed job:

@rust-bors rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 19, 2026
@rust-bors

rust-bors Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

PR #161277, which is a member of this rollup, was unapproved.

@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Aug 19, 2026
@rust-log-analyzer

Copy link
Copy Markdown
Collaborator

The job dist-x86_64-msvc failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
  |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  |
  = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default

error: `bootstrap` (lib) generated 1 warning (run `cargo fix --lib -p bootstrap` to apply 1 suggestion)
error: warnings are denied by `build.warnings` configuration
failed to run: C:\a\rust\rust\build\x86_64-pc-windows-msvc\stage0\bin\cargo.exe build --jobs=default --manifest-path C:\a\rust\rust\src/bootstrap/Cargo.toml -Zroot-dir=C:\a\rust\rust --locked --features build-metrics
Build completed unsuccessfully in 0:00:46
make: *** [Makefile:102: prepare] Error 1
Command failed. Attempt 2/5:
##[group]Building bootstrap
warning: unused import: `crate::core::session::Build`
##[warning] --> src\bootstrap\src\utils\job.rs:4:5
  |
4 | use crate::core::session::Build;
  |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  |
  = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default

error: `bootstrap` (lib) generated 1 warning (run `cargo fix --lib -p bootstrap` to apply 1 suggestion)
error: warnings are denied by `build.warnings` configuration
failed to run: C:\a\rust\rust\build\x86_64-pc-windows-msvc\stage0\bin\cargo.exe build --jobs=default --manifest-path C:\a\rust\rust\src/bootstrap/Cargo.toml -Zroot-dir=C:\a\rust\rust --locked --features build-metrics
Build completed unsuccessfully in 0:00:00
make: *** [Makefile:102: prepare] Error 1
Command failed. Attempt 3/5:
##[group]Building bootstrap
warning: unused import: `crate::core::session::Build`
##[warning] --> src\bootstrap\src\utils\job.rs:4:5
  |
4 | use crate::core::session::Build;
  |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  |
  = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default

error: `bootstrap` (lib) generated 1 warning (run `cargo fix --lib -p bootstrap` to apply 1 suggestion)
error: warnings are denied by `build.warnings` configuration
failed to run: C:\a\rust\rust\build\x86_64-pc-windows-msvc\stage0\bin\cargo.exe build --jobs=default --manifest-path C:\a\rust\rust\src/bootstrap/Cargo.toml -Zroot-dir=C:\a\rust\rust --locked --features build-metrics
Build completed unsuccessfully in 0:00:00
make: *** [Makefile:102: prepare] Error 1
Command failed. Attempt 4/5:
##[group]Building bootstrap
warning: unused import: `crate::core::session::Build`
##[warning] --> src\bootstrap\src\utils\job.rs:4:5
  |
4 | use crate::core::session::Build;
  |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  |
  = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default

error: `bootstrap` (lib) generated 1 warning (run `cargo fix --lib -p bootstrap` to apply 1 suggestion)
error: warnings are denied by `build.warnings` configuration
failed to run: C:\a\rust\rust\build\x86_64-pc-windows-msvc\stage0\bin\cargo.exe build --jobs=default --manifest-path C:\a\rust\rust\src/bootstrap/Cargo.toml -Zroot-dir=C:\a\rust\rust --locked --features build-metrics
Build completed unsuccessfully in 0:00:00
make: *** [Makefile:102: prepare] Error 1
Command failed. Attempt 5/5:
##[group]Building bootstrap
warning: unused import: `crate::core::session::Build`
##[warning] --> src\bootstrap\src\utils\job.rs:4:5
  |
4 | use crate::core::session::Build;
  |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  |
  = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default

error: `bootstrap` (lib) generated 1 warning (run `cargo fix --lib -p bootstrap` to apply 1 suggestion)
error: warnings are denied by `build.warnings` configuration
failed to run: C:\a\rust\rust\build\x86_64-pc-windows-msvc\stage0\bin\cargo.exe build --jobs=default --manifest-path C:\a\rust\rust\src/bootstrap/Cargo.toml -Zroot-dir=C:\a\rust\rust --locked --features build-metrics
Build completed unsuccessfully in 0:00:00
make: *** [Makefile:102: prepare] Error 1
The command has failed after 5 attempts.
  local time: Wed Aug 19 14:17:00 CUT 2026
  network time: Wed, 19 Aug 2026 14:17:00 GMT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-bootstrap-stamp Area: bootstrap stamp logic A-CI Area: Our Github Actions CI A-meta Area: Issues & PRs about the rust-lang/rust repository itself A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) A-testsuite Area: The testsuite used to check the correctness of rustc PG-exploit-mitigations Project group: Exploit mitigations rollup A PR which is a rollup T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)

Projects

None yet

Development

Successfully merging this pull request may close these issues.