Skip to content

[experiment]: Skip match simplification - #161097

Draft
makai410 wants to merge 1 commit into
rust-lang:mainfrom
makai410:no-match-simp
Draft

[experiment]: Skip match simplification#161097
makai410 wants to merge 1 commit into
rust-lang:mainfrom
makai410:no-match-simp

Conversation

@makai410

Copy link
Copy Markdown
Member

r? @ghost

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 14, 2026
@tmiasko

tmiasko commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 14, 2026
@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Aug 14, 2026
[experiment]: Skip match simplification
@rust-bors

rust-bors Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 1d8cc2b (1d8cc2be9340db2dbd2455ecb599b693900a729f)
Base parent: a9066b3 (a9066b3a6e6a0956706c77c49f24a8d258c5ed3b)

@rust-timer

This comment has been minimized.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (1d8cc2b): comparison URL.

Overall result: ❌✅ regressions and improvements - please read:

Benchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf.

Next, please: If you can, justify the regressions found in this try perf run in writing along with @rustbot label: +perf-regression-triaged. If not, fix the regressions and do another perf run. Neutral or positive results will clear the label automatically.

@bors rollup=never rustc-perf
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
0.3% [0.1%, 0.9%] 12
Regressions ❌
(secondary)
0.6% [0.1%, 3.0%] 39
Improvements ✅
(primary)
-0.4% [-3.4%, -0.1%] 28
Improvements ✅
(secondary)
-0.8% [-7.3%, -0.1%] 20
All ❌✅ (primary) -0.2% [-3.4%, 0.9%] 40

Max RSS (memory usage)

This perf run didn't have relevant results for this metric.

Cycles

Results (primary 0.2%, secondary -8.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
2.4% [2.4%, 2.4%] 1
Regressions ❌
(secondary)
3.2% [3.0%, 3.3%] 2
Improvements ✅
(primary)
-2.1% [-2.1%, -2.1%] 1
Improvements ✅
(secondary)
-11.3% [-22.6%, -2.0%] 7
All ❌✅ (primary) 0.2% [-2.1%, 2.4%] 2

Binary size

Results (primary -0.1%, secondary -0.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
0.1% [0.0%, 0.3%] 18
Regressions ❌
(secondary)
1.1% [0.0%, 3.4%] 9
Improvements ✅
(primary)
-0.3% [-1.1%, -0.0%] 18
Improvements ✅
(secondary)
-0.8% [-1.1%, -0.0%] 57
All ❌✅ (primary) -0.1% [-1.1%, 0.3%] 36

Bootstrap: 457.276s -> 457.521s (0.05%)
Artifact size: 396.43 MiB -> 396.37 MiB (-0.01%)

@rustbot rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Aug 14, 2026
@rust-bors

rust-bors Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

☔ The latest upstream changes (presumably #161338) made this pull request unmergeable. Please resolve the merge conflicts by rebasing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

perf-regression Performance regression. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants