tidy: Update Python version requirements to 3.11 by marcoieni · Pull Request #160896 · rust-lang/rust

marcoieni · 2026-08-11T07:33:55Z

Similar to #160429
I'm updating to 3.11 as requested in #160429 (comment) because 3.10 is EOL in 2 months.

AI disclosure

gpt 5.6 sol helped me troubleshoot/investigate this task and it generated parts of the code of this PR (mainly in the changes of the Dockerfile).

I think my use of LLMs in this case can be categorized under “Trivial” code, so I guess it's fine.

marcoieni · 2026-08-11T07:34:25Z

@@ -1,5 +1,5 @@
 #
-# This file is autogenerated by pip-compile with Python 3.10
+# This file is autogenerated by pip-compile with Python 3.11


To update this file I ran:

docker run --rm \ -v "$PWD":/workspace \ -w /workspace \ python:3.11-slim \ bash -c ' python -m pip install --no-cache-dir \ pip-tools==7.5.3 \ && pip-compile --generate-hashes --strip-extras \ src/tools/tidy/config/requirements.in '

View changes since the review

marcoieni · 2026-08-11T08:23:34Z

 FROM ghcr.io/rust-lang/ubuntu:22.04

 ARG DEBIAN_FRONTEND=noninteractive
+# Install python3.11 because python3 in ubuntu22 resolves to python3.10, which is EOL in October 2026.


I couldn't update to ubuntu 24 because python2.7 is not available there from apt.

View changes since the review

As discussed in #t-infra/bootstrap > Do we need to support Python 2?, we should just kick out the Python 2.7 package.

rustbot · 2026-08-11T08:38:18Z

tidy extra checks were modified.

cc @lolbinarycat

rustbot · 2026-08-11T08:38:21Z

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: bootstrap
bootstrap expanded to 6 candidates
Random selection from Mark-Simulacrum, clubby789, jieyouxu

jieyouxu

Thanks. One non-blocking thought, r=me with or without.

View changes since this review

jieyouxu · 2026-08-13T04:56:51Z

@rustbot author

rustbot · 2026-08-13T10:59:15Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

marcoieni · 2026-08-13T11:01:13Z

-COPY host-x86_64/pr-check-1/reuse-requirements.txt /tmp/
-RUN pip3 install --no-deps --no-cache-dir --require-hashes -r /tmp/reuse-requirements.txt \
-  && pip3 install virtualenv


AI found out that reuse is not used in tidy. It is only used in pr-check-1:

rust/src/ci/docker/host-x86_64/pr-check-1/Dockerfile

Line 62 in 1e5ee35

reuse --include-submodules lint && \

View changes since the review

marcoieni · 2026-08-13T11:02:18Z

-# We use the ghcr base image because ghcr doesn't have a rate limit
-# and the tidy job doesn't cache docker images in CI.
-FROM ghcr.io/rust-lang/ubuntu:22.04
+FROM ubuntu:26.04


There shouldn't be issues with the Docker rate limits in GitHub Actions because GitHub Actions have their own mirror of Docker images as far as I know.
ghcr is only handy when running github actions in other runner providers, like aws.

View changes since the review

marcoieni · 2026-08-13T11:04:37Z

-# NOTE: intentionally uses python2 for x.py so we can test it still works.
-# validate-toolstate only runs in our CI, so it's ok for it to only support python3.
-ENV SCRIPT="python2.7 ../x.py test src/tools/tidy tidyselftest --extra-checks=py,cpp,js,spellcheck"
+ENV SCRIPT="python3 ../x.py test src/tools/tidy tidyselftest --extra-checks=py,cpp,js,spellcheck"


python3 in ubuntu 26 resolves to python 3.14.4. I hope it's fine.
Should we run with the minimum version we declare (python 3.11) instead?

View changes since the review

That should be fine, we usually have problems with py versions too old

I switched to ubuntu 24 where the default python is 3.12 so that at least it's a bit older than 3.14

marcoieni · 2026-08-13T11:09:04Z

  python3 \
-  python3-pip \
-  python3-pkg-resources \
+  python3-venv \


On Ubuntu 24.04, python3 only suggests python3-venv, so we need to install it.

Venv is used by tidy you can see:

rust/src/tools/tidy/src/extra_checks/mod.rs

Line 563 in 1e5ee35

fn create_venv_at_path(path: &Path) -> Result<(), Error> {

View changes since the review

jieyouxu

Thanks
@bors r+

View changes since this review

rust-bors · 2026-08-13T12:17:50Z

📌 Commit 948b5ab has been approved by jieyouxu

It is now in the queue for this repository.

…ouxu tidy: Update Python version requirements to 3.11 Similar to rust-lang#160429 I'm updating to 3.11 as requested in rust-lang#160429 (comment) because 3.10 is EOL in 2 months. ## AI disclosure gpt 5.6 sol helped me troubleshoot/investigate this task and it generated parts of the code of this PR (mainly in the changes of the Dockerfile). I think my use of LLMs in this case can be categorized under [`“Trivial” code`](https://forge.rust-lang.org/policies/llm-usage.html#-allowed-with-caveats), so I guess it's fine.

Rollup of 14 pull requests Successful merges: - #158918 (x86_64-win: Enable f128 on LLVM 23+) - #160288 (rustdoc: use anonymous constant for primitives/keywords/attribute docs) - #160440 (Couple of misc improvements to the unwind infrastructure) - #160441 (PowerPC inline ASM: Fix scalar floats being in the wrong vector lane on little endian) - #160896 (tidy: Update Python version requirements to 3.11) - #160972 (std: map ERROR_NEGATIVE_SEEK to ErrorKind::InvalidInput on Windows) - #161040 (Optimize CStr backing slice bounds checks) - #158885 (Add `core::num::Complex`) - #160928 (check `mut`-restriction when tuple constructor is used as a value) - #161002 (disallow `#[cold]` on `extern "custom"` functions) - #161016 (Fix invalid suggestion from try unlabled block) - #161020 (io: Use `NonNull` for all `Custom` API related to `Box`, update documentation for `Custom`) - #161044 (rustc-dev-guide subtree update) - #161046 (Enable unrolling feature of bors)

…ouxu tidy: Update Python version requirements to 3.11 Similar to rust-lang#160429 I'm updating to 3.11 as requested in rust-lang#160429 (comment) because 3.10 is EOL in 2 months. ## AI disclosure gpt 5.6 sol helped me troubleshoot/investigate this task and it generated parts of the code of this PR (mainly in the changes of the Dockerfile). I think my use of LLMs in this case can be categorized under [`“Trivial” code`](https://forge.rust-lang.org/policies/llm-usage.html#-allowed-with-caveats), so I guess it's fine.

…uwer Rollup of 17 pull requests Successful merges: - #161045 (stdarch subtree update) - #157428 (allocator: refactor for stabilisation) - #158918 (x86_64-win: Enable f128 on LLVM 23+) - #160288 (rustdoc: use anonymous constant for primitives/keywords/attribute docs) - #160440 (Couple of misc improvements to the unwind infrastructure) - #160441 (PowerPC inline ASM: Fix scalar floats being in the wrong vector lane on little endian) - #160896 (tidy: Update Python version requirements to 3.11) - #160972 (std: map ERROR_NEGATIVE_SEEK to ErrorKind::InvalidInput on Windows) - #161040 (Optimize CStr backing slice bounds checks) - #160928 (check `mut`-restriction when tuple constructor is used as a value) - #160969 (give layout errors from `size_of_val` and `align_of_val` a span) - #161002 (disallow `#[cold]` on `extern "custom"` functions) - #161016 (Fix invalid suggestion from try unlabled block) - #161020 (io: Use `NonNull` for all `Custom` API related to `Box`, update documentation for `Custom`) - #161044 (rustc-dev-guide subtree update) - #161046 (Enable unrolling feature of bors) - #161054 (rustdoc: Fix link title attribute value when field of enum variants)

Rollup of 23 pull requests Successful merges: - #157428 (allocator: refactor for stabilisation) - #158918 (x86_64-win: Enable f128 on LLVM 23+) - #160077 (Don't compute FnAbi for LLVM intrinsics) - #160288 (rustdoc: use anonymous constant for primitives/keywords/attribute docs) - #160440 (Couple of misc improvements to the unwind infrastructure) - #160896 (tidy: Update Python version requirements to 3.11) - #160972 (std: map ERROR_NEGATIVE_SEEK to ErrorKind::InvalidInput on Windows) - #160984 (Fix ICE on { _ } const args in bodies by tracking const-only infer args) - #161036 (Use `with_types_for_suggestion!` in `write_struct_like()`) - #161037 (std: don't clean up the main thread's altstack) - #161040 (Optimize CStr backing slice bounds checks) - #161065 (core: Fix a typo in funnel shift documentation) - #158885 (Add `core::num::Complex`) - #160928 (check `mut`-restriction when tuple constructor is used as a value) - #160969 (give layout errors from `size_of_val` and `align_of_val` a span) - #161002 (disallow `#[cold]` on `extern "custom"` functions) - #161016 (Fix invalid suggestion from try unlabled block) - #161020 (io: Use `NonNull` for all `Custom` API related to `Box`, update documentation for `Custom`) - #161044 (rustc-dev-guide subtree update) - #161046 (Enable unrolling feature of bors) - #161054 (rustdoc: Fix link title attribute value when field of enum variants) - #161055 (`offload!` function-like macro) - #161064 (Revert "riscv: promote d, e, and f target_features to CfgStableToggleUnstable")

Rollup merge of #160896 - marcoieni:tidy-python-3.11, r=jieyouxu tidy: Update Python version requirements to 3.11 Similar to #160429 I'm updating to 3.11 as requested in #160429 (comment) because 3.10 is EOL in 2 months. ## AI disclosure gpt 5.6 sol helped me troubleshoot/investigate this task and it generated parts of the code of this PR (mainly in the changes of the Dockerfile). I think my use of LLMs in this case can be categorized under [`“Trivial” code`](https://forge.rust-lang.org/policies/llm-usage.html#-allowed-with-caveats), so I guess it's fine.

rustbot added A-tidy Area: The tidy tool S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Aug 11, 2026

marcoieni commented Aug 11, 2026

View reviewed changes

Kobzol reviewed Aug 11, 2026

View reviewed changes

Comment thread src/tools/tidy/src/extra_checks/mod.rs Outdated

This comment has been minimized.

Sign in to view

marcoieni force-pushed the tidy-python-3.11 branch from 3194a6b to dfe7f30 Compare August 11, 2026 08:08

This comment has been minimized.

Sign in to view

marcoieni force-pushed the tidy-python-3.11 branch from dfe7f30 to dee0f81 Compare August 11, 2026 08:22

rustbot added A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Aug 11, 2026

marcoieni commented Aug 11, 2026

View reviewed changes

marcoieni marked this pull request as ready for review August 11, 2026 08:38

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 11, 2026

rustbot assigned jieyouxu Aug 11, 2026

jieyouxu approved these changes Aug 12, 2026

View reviewed changes

Comment thread src/ci/docker/host-x86_64/tidy/Dockerfile Outdated

Comment thread src/tools/tidy/src/extra_checks/mod.rs

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 13, 2026

marcoieni force-pushed the tidy-python-3.11 branch from dee0f81 to 92a94d6 Compare August 13, 2026 10:59

marcoieni commented Aug 13, 2026

View reviewed changes

marcoieni marked this pull request as draft August 13, 2026 11:10

tidy: Update Python version requirements to 3.11

948b5ab

marcoieni force-pushed the tidy-python-3.11 branch from 92a94d6 to 948b5ab Compare August 13, 2026 11:27

marcoieni marked this pull request as ready for review August 13, 2026 11:40

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 13, 2026

marcoieni requested a review from jieyouxu August 13, 2026 11:40

jieyouxu approved these changes Aug 13, 2026

View reviewed changes

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 13, 2026

jhpratt mentioned this pull request Aug 13, 2026

Rollup of 14 pull requests #161056

Closed

JonathanBrouwer mentioned this pull request Aug 13, 2026

Rollup of 17 pull requests #161066

Closed

jhpratt mentioned this pull request Aug 13, 2026

Rollup of 23 pull requests #161075

Merged

rust-bors Bot merged commit e1ce7da into rust-lang:main Aug 14, 2026
13 checks passed

rustbot added this to the 1.99.0 milestone Aug 14, 2026

Uh oh!

Uh oh!

Conversation

marcoieni commented Aug 11, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

AI disclosure

Uh oh!

marcoieni Aug 11, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

marcoieni Aug 11, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jieyouxu Aug 12, 2026

Choose a reason for hiding this comment

Uh oh!

rustbot commented Aug 11, 2026

Uh oh!

rustbot commented Aug 11, 2026

Uh oh!

jieyouxu left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jieyouxu commented Aug 13, 2026

Uh oh!

rustbot commented Aug 13, 2026

Uh oh!

marcoieni Aug 13, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

marcoieni Aug 13, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

marcoieni Aug 13, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jieyouxu Aug 13, 2026

Choose a reason for hiding this comment

Uh oh!

marcoieni Aug 13, 2026

Choose a reason for hiding this comment

Uh oh!

marcoieni Aug 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jieyouxu left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rust-bors Bot commented Aug 13, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

marcoieni commented Aug 11, 2026 •

edited by rustbot

Loading

marcoieni Aug 11, 2026 •

edited by rustbot

Loading

marcoieni Aug 11, 2026 •

edited by rustbot

Loading

jieyouxu left a comment •

edited

Loading

marcoieni Aug 13, 2026 •

edited by rustbot

Loading

marcoieni Aug 13, 2026 •

edited by rustbot

Loading

marcoieni Aug 13, 2026 •

edited by rustbot

Loading

marcoieni Aug 13, 2026 •

edited

Loading

jieyouxu left a comment •

edited by rustbot

Loading