Use remove_dir_all for ./x clean - #160852
Merged
Merged
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
r? @jieyouxu rustbot has assigned @jieyouxu. Use Why was this reviewer chosen?The reviewer was selected based on:
|
ChrisDenton
commented
Aug 10, 2026
jieyouxu
approved these changes
Aug 10, 2026
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 10, 2026
Use `remove_dir_all` for `./x clean` This should work better in most cases (and be faster) particularly on Windows. I've left the old implementation more or less intact to provide diagnostics on failure. But it could be removed if desired.
This was referenced Aug 10, 2026
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 10, 2026
…uwer Rollup of 9 pull requests Successful merges: - #158404 (trait_solver: normalize next-gen region constraints) - #160631 (Do not eagerly download rustfmt in bootstrap) - #160642 (mir: prohibit projection into scalable vec) - #160749 (MaybeDangling: ensure references fit inside the address space) - #160791 (Use recognizer functions for enums and tuple structs) - #160500 (Fix inaccurate description for crate and pathroot) - #160590 (Docs & bors: Replace mentions of libs-api with libs) - #160825 (Fix references to unsupported on sys::paths::unix) - #160852 (Use `remove_dir_all` for `./x clean`) Failed merges: - #160829 (bootstrap: Make `main.rs` a stub that calls into the library crate)
rust-timer
added a commit
that referenced
this pull request
Aug 10, 2026
Rollup merge of #160852 - ChrisDenton:rmdirall, r=jieyouxu Use `remove_dir_all` for `./x clean` This should work better in most cases (and be faster) particularly on Windows. I've left the old implementation more or less intact to provide diagnostics on failure. But it could be removed if desired.
github-actions Bot
pushed a commit
to rust-lang/rustc-dev-guide
that referenced
this pull request
Aug 11, 2026
…uwer Rollup of 9 pull requests Successful merges: - rust-lang/rust#158404 (trait_solver: normalize next-gen region constraints) - rust-lang/rust#160631 (Do not eagerly download rustfmt in bootstrap) - rust-lang/rust#160642 (mir: prohibit projection into scalable vec) - rust-lang/rust#160749 (MaybeDangling: ensure references fit inside the address space) - rust-lang/rust#160791 (Use recognizer functions for enums and tuple structs) - rust-lang/rust#160500 (Fix inaccurate description for crate and pathroot) - rust-lang/rust#160590 (Docs & bors: Replace mentions of libs-api with libs) - rust-lang/rust#160825 (Fix references to unsupported on sys::paths::unix) - rust-lang/rust#160852 (Use `remove_dir_all` for `./x clean`) Failed merges: - rust-lang/rust#160829 (bootstrap: Make `main.rs` a stub that calls into the library crate)
bjorn3
pushed a commit
to bjorn3/stdarch
that referenced
this pull request
Aug 13, 2026
…uwer Rollup of 9 pull requests Successful merges: - rust-lang/rust#158404 (trait_solver: normalize next-gen region constraints) - rust-lang/rust#160631 (Do not eagerly download rustfmt in bootstrap) - rust-lang/rust#160642 (mir: prohibit projection into scalable vec) - rust-lang/rust#160749 (MaybeDangling: ensure references fit inside the address space) - rust-lang/rust#160791 (Use recognizer functions for enums and tuple structs) - rust-lang/rust#160500 (Fix inaccurate description for crate and pathroot) - rust-lang/rust#160590 (Docs & bors: Replace mentions of libs-api with libs) - rust-lang/rust#160825 (Fix references to unsupported on sys::paths::unix) - rust-lang/rust#160852 (Use `remove_dir_all` for `./x clean`) Failed merges: - rust-lang/rust#160829 (bootstrap: Make `main.rs` a stub that calls into the library crate)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should work better in most cases (and be faster) particularly on Windows. I've left the old implementation more or less intact to provide diagnostics on failure. But it could be removed if desired.