Skip to content

arm64ec: f128 is supported since LLVM 23 - #160779

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
folkertdev:arm64ec-f128
Aug 9, 2026
Merged

arm64ec: f128 is supported since LLVM 23#160779
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
folkertdev:arm64ec-f128

Conversation

@folkertdev

Copy link
Copy Markdown
Contributor

tracking issue: #116909

  • I did not use an LLM to create a change in this PR.
  • I used an LLM to create a change in this PR, and I have explained below how it was used.

Related

cc @dpaoliello (feel free to approve also, and maybe you can validate this in practice?)
r? tgross35

@folkertdev folkertdev added the F-f16_and_f128 `#![feature(f16)]`, `#![feature(f128)]` label Aug 8, 2026
@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 8, 2026
@rustbot

rustbot commented Aug 8, 2026

Copy link
Copy Markdown
Collaborator

tgross35 is currently at their maximum review capacity.
They may take a while to respond.

@tgross35 tgross35 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed it is

@bors r+ rollup

View changes since this review

@rust-bors

rust-bors Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 82b020e has been approved by tgross35

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 9, 2026
@tgross35

tgross35 commented Aug 9, 2026

Copy link
Copy Markdown
Member

Ah actually we do build this in CI, may as well check for surprises.

@bors r-
@bors try jobs=dist-aarch64-msvc

r=me after

@rust-bors rust-bors Bot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Aug 9, 2026
@rust-bors

rust-bors Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

This pull request was unapproved.

View changes since this unapproval

@rust-bors rust-bors Bot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 9, 2026
@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Aug 9, 2026
arm64ec: `f128` is supported since LLVM 23


try-job: dist-aarch64-msvc
@rust-bors

rust-bors Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 558a320 (558a320150db5ef21fa113b36dfb292fccfb744a)
Base parent: 4667d75 (4667d75565e47ba5df36c0df598c556b543e8624)

@tgross35

tgross35 commented Aug 9, 2026

Copy link
Copy Markdown
Member

@bors r+

@rust-bors

rust-bors Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 82b020e has been approved by tgross35

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 9, 2026
jhpratt added a commit to jhpratt/rust that referenced this pull request Aug 9, 2026
arm64ec: `f128` is supported since LLVM 23

tracking issue: rust-lang#116909

- [x] I did not use an LLM to create a change in this PR.
- [ ] I used an LLM to create a change in this PR, and I have explained below how it was used.

Related

- llvm/llvm-project#94434
- llvm/llvm-project#206980

cc @dpaoliello (feel free to approve also, and maybe you can validate this in practice?)
r? tgross35
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Aug 9, 2026
arm64ec: `f128` is supported since LLVM 23

tracking issue: rust-lang#116909

- [x] I did not use an LLM to create a change in this PR.
- [ ] I used an LLM to create a change in this PR, and I have explained below how it was used.

Related

- llvm/llvm-project#94434
- llvm/llvm-project#206980

cc @dpaoliello (feel free to approve also, and maybe you can validate this in practice?)
r? tgross35
rust-bors Bot pushed a commit that referenced this pull request Aug 9, 2026
…uwer

Rollup of 9 pull requests

Successful merges:

 - #160782 (rustc_attr_ir: fix up `lang_items` imports)
 - #159746 (stabilize `c_variadic_naked_functions`)
 - #160141 (Refactor tidy detection of stability attribute)
 - #160744 (make more diagnostic structs pub(crate))
 - #160778 (Add regression test for cycle error on guaranteed unsized self type)
 - #160779 (arm64ec: `f128` is supported since LLVM 23)
 - #160781 (Add regression test for save temps ICE on incremental recompile)
 - #160792 (User facing .expect now follows “expect as precondition" style)
 - #160796 (Change .expect message to follow precondition style)
@rust-bors
rust-bors Bot merged commit 6b00b67 into rust-lang:main Aug 9, 2026
14 checks passed
@rustbot rustbot added this to the 1.99.0 milestone Aug 9, 2026
rust-timer added a commit that referenced this pull request Aug 9, 2026
Rollup merge of #160779 - folkertdev:arm64ec-f128, r=tgross35

arm64ec: `f128` is supported since LLVM 23

tracking issue: #116909

- [x] I did not use an LLM to create a change in this PR.
- [ ] I used an LLM to create a change in this PR, and I have explained below how it was used.

Related

- llvm/llvm-project#94434
- llvm/llvm-project#206980

cc @dpaoliello (feel free to approve also, and maybe you can validate this in practice?)
r? tgross35
flip1995 pushed a commit to flip1995/rust-clippy that referenced this pull request Aug 17, 2026
…uwer

Rollup of 9 pull requests

Successful merges:

 - rust-lang/rust#160782 (rustc_attr_ir: fix up `lang_items` imports)
 - rust-lang/rust#159746 (stabilize `c_variadic_naked_functions`)
 - rust-lang/rust#160141 (Refactor tidy detection of stability attribute)
 - rust-lang/rust#160744 (make more diagnostic structs pub(crate))
 - rust-lang/rust#160778 (Add regression test for cycle error on guaranteed unsized self type)
 - rust-lang/rust#160779 (arm64ec: `f128` is supported since LLVM 23)
 - rust-lang/rust#160781 (Add regression test for save temps ICE on incremental recompile)
 - rust-lang/rust#160792 (User facing .expect now follows “expect as precondition" style)
 - rust-lang/rust#160796 (Change .expect message to follow precondition style)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. F-f16_and_f128 `#![feature(f16)]`, `#![feature(f128)]` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants