enable next solver by default in orphanck

[sjwang05]

View all comments

• I did not use an LLM to create a change in this PR.
• I used an LLM to create a change in this PR, and I have explained below how it was used.

Orphan checking was supposed to use next solver as well when -Znext-solver=coherence got stabilized, but it never actually did, so this PR fixes that as part of the effort here: #t-types/call-for-participation > rip out old solver coherence support @ 💬

also fixes #149703 and #148621, incidentally!

r? lcnr

[rustbot]

This PR changes a file inside tests/crashes. If a crash was fixed, please move into the corresponding ui subdir and add 'Fixes #' to the PR description to autoclose the issue upon merge.

[adwinwhite]

@bors try @rust-timer queue

[rust-bors]

☀️ Try build successful (CI)
Build commit: c029389 (c029389d9a6de885e84a538a6618e9ccc532787d)
Base parent: 84b36a7 (84b36a78a28a63f134171c670be1932ffa2485f8)

[lcnr]

any breakage caused by this would also be caught by #133502. So I don't think this needs a separate crater run actually

[lcnr]

@rfcbot fcp merge types

[rust-rfcbot]

@lcnr has proposed to merge this. The next step is review by the rest of the tagged team members:

• @BoxyUwU
• @jackh726
• @lcnr
• @oli-obk
• @spastorino

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

[rust-rfcbot]

🔔 This is now entering its final comment period, as per the review above. 🔔

[rust-timer]

Finished benchmarking commit (c029389): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf.

@bors rollup=never rustc-perf
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.4%	[-0.4%, -0.4%]	1
Improvements ✅ (secondary)	-0.4%	[-0.5%, -0.2%]	7
All ❌✅ (primary)	-0.4%	[-0.4%, -0.4%]	1

Max RSS (memory usage)

Results (primary -4.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-4.2%	[-5.8%, -2.6%]	2
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-4.2%	[-5.8%, -2.6%]	2

Cycles

This perf run didn't have relevant results for this metric.

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 457.798s -> 459.043s (0.27%)
Artifact size: 399.35 MiB -> 398.65 MiB (-0.18%)

[rust-rfcbot]

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

[lcnr]

@bors r+

[rust-bors]

📌 Commit 213ca22 has been approved by lcnr

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 5. This pull request will be tested once the tree is reopened.

Reason for tree closure: github outage

[rust-bors]

💔 Test for 27fcc14 failed: CI. Failed job:

• auto - x86_64-gnu-llvm-21-3 (web logs, enhanced plaintext logs)

[rustbot]

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

[sjwang05]

Huh, new crashtest that this PR also fixes. Rebased and updated everything, including the PR description.

[lcnr]

@bors r+

[rust-bors]

📌 Commit 536b23e has been approved by lcnr

It is now in the queue for this repository.

[rust-bors]

☀️ Test successful - CI
Approved by: lcnr
Duration: 3h 16m 55s
Pushing 444dcce to main...

[github-actions]

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 19523e0 (parent) -> 444dcce (this PR)

Test differences

Show 20 test diffs

Stage 1

• [ui (polonius)] tests/ui/coherence/const-trait-impl-orphanck.rs: [missing] -> pass (J0)
• [ui (polonius)] tests/ui/type-alias-impl-trait/coherence/coherence.rs: [missing] -> pass (J0)
• [ui (polonius)] tests/ui/type-alias-impl-trait/coherence/coherence.rs#classic: pass -> [missing] (J0)
• [ui (polonius)] tests/ui/type-alias-impl-trait/coherence/coherence.rs#next: pass -> [missing] (J0)
• [ui (polonius)] tests/ui/type-alias-impl-trait/coherence/orphanck-tait-with-projection-arg.rs: [missing] -> pass (J0)
• [ui] tests/ui/coherence/const-trait-impl-orphanck.rs: [missing] -> pass (J1)
• [ui] tests/ui/type-alias-impl-trait/coherence/coherence.rs: [missing] -> pass (J1)
• [ui] tests/ui/type-alias-impl-trait/coherence/coherence.rs#classic: pass -> [missing] (J1)
• [ui] tests/ui/type-alias-impl-trait/coherence/coherence.rs#next: pass -> [missing] (J1)
• [ui] tests/ui/type-alias-impl-trait/coherence/orphanck-tait-with-projection-arg.rs: [missing] -> pass (J1)
• [crashes] tests/crashes/148621.rs: pass -> [missing] (J3)
• [crashes] tests/crashes/149703.rs: pass -> [missing] (J3)

Stage 2

• [ui] tests/ui/coherence/const-trait-impl-orphanck.rs: [missing] -> pass (J2)
• [ui] tests/ui/type-alias-impl-trait/coherence/coherence.rs: [missing] -> pass (J2)
• [ui] tests/ui/type-alias-impl-trait/coherence/coherence.rs#classic: pass -> [missing] (J2)
• [ui] tests/ui/type-alias-impl-trait/coherence/coherence.rs#next: pass -> [missing] (J2)
• [ui] tests/ui/type-alias-impl-trait/coherence/orphanck-tait-with-projection-arg.rs: [missing] -> pass (J2)
• [crashes] tests/crashes/148621.rs: pass -> [missing] (J4)
• [crashes] tests/crashes/149703.rs: pass -> [missing] (J4)

Additionally, 1 doctest diff were found. These are ignored, as they are noisy.

Job group index

• J0: x86_64-gnu-next-trait-solver-polonius
• J1: x86_64-gnu-llvm-21-3, x86_64-gnu-llvm-22-3, x86_64-gnu-next-trait-solver-polonius
• J2: aarch64-apple-1, aarch64-apple-macos-26-1, aarch64-gnu, aarch64-gnu-llvm-21-1, aarch64-msvc-1, arm-android, armhf-gnu, i686-gnu-1, i686-gnu-nopt-1, i686-msvc-1, test-various, x86_64-gnu, x86_64-gnu-debug, x86_64-gnu-gcc, x86_64-gnu-llvm-21, x86_64-gnu-llvm-21-2, x86_64-gnu-llvm-22-2, x86_64-gnu-nopt, x86_64-gnu-parallel-frontend, x86_64-gnu-stable, x86_64-mingw-1, x86_64-msvc-1
• J3: x86_64-gnu-llvm-21-3, x86_64-gnu-llvm-22-3
• J4: aarch64-apple-1, aarch64-apple-macos-26-1, aarch64-gnu, aarch64-gnu-llvm-21-1, aarch64-msvc-1, arm-android, armhf-gnu, i686-gnu-1, i686-gnu-nopt-1, i686-msvc-1, test-various, x86_64-gnu, x86_64-gnu-gcc, x86_64-gnu-llvm-21-2, x86_64-gnu-llvm-22-2, x86_64-gnu-nopt, x86_64-gnu-stable, x86_64-mingw-1, x86_64-msvc-1

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 444dcce484c66c8d626806a8556be3b4d3ef381a --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

1. x86_64-gnu-stdlib-semver-check: 13m 9s -> 6m 3s (-53.9%)
2. dist-armv7-linux: 1h 7m -> 1h 30m (+34.0%)
3. optional-x86_64-gnu-autodiff: 35m 45s -> 47m 52s (+33.9%)
4. i686-gnu-nopt-1: 2h 17m -> 1h 31m (-33.7%)
5. x86_64-msvc-ext3: 1h 16m -> 1h 40m (+31.5%)
6. x86_64-gnu-distcheck: 2h 12m -> 1h 31m (-30.8%)
7. dist-ohos-x86_64: 59m 34s -> 1h 17m (+29.7%)
8. dist-aarch64-apple: 1h 51m -> 2h 23m (+29.4%)
9. x86_64-gnu-llvm-21-3: 1h 21m -> 1h 44m (+28.3%)
10. x86_64-gnu-llvm-22-1: 1h 11m -> 51m 35s (-28.2%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

[rust-timer]

Finished benchmarking commit (444dcce): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

This perf run didn't have relevant results for this metric.

Cycles

Results (secondary 1.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	4.0%	[4.0%, 4.0%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.9%	[-1.9%, -1.9%]	1
All ❌✅ (primary)	-	-	0

Binary size

Results (secondary -0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.0%	[-0.0%, -0.0%]	15
All ❌✅ (primary)	-	-	0

Bootstrap: 457.924s -> 455.347s (-0.56%)
Artifact size: 398.97 MiB -> 398.98 MiB (0.00%)