Skip to content

Update expect messages for library/alloc/src/vec/mod.rs - #159862

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
Saitock:fix_expect
Aug 15, 2026
Merged

Update expect messages for library/alloc/src/vec/mod.rs#159862
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
Saitock:fix_expect

Conversation

@Saitock

@Saitock Saitock commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Related issue: #159751
Updated some expect messages for library/alloc/src/vec/mod.rs

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 24, 2026
@rustbot

rustbot commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the pull request, and welcome! The Rust Project is excited to review your changes, and you should hear from @JohnTitor (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue
Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: libs
  • libs expanded to 12 candidates
  • Random selection from 6 candidates

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rustbot

rustbot commented Jul 25, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@rustbot

This comment has been minimized.

Sign in to view
@rustbot rustbot added has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 25, 2026
@rustbot

This comment has been minimized.

Sign in to view
@rustbot

This comment has been minimized.

Sign in to view
@rustbot rustbot removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. has-merge-commits PR has merge commits, merge with caution. labels Jul 25, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
Lars-Schumann
Lars-Schumann reviewed Jul 25, 2026
View reviewed changes
Comment thread library/alloctests/tests/vec.rs

#[test]
#[should_panic = "vec len overflow"]
#[should_panic = "the product of vec len and N shouldn't overflow"]

@Lars-Schumann Lars-Schumann Jul 25, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

surely since this is a should_panic this should read should overflow?
usize::MAX * 2 certainly seems like it would ^^

View changes since the review

@Saitock Saitock Jul 25, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, my bad, fixing it now Orz

@JohnTitor JohnTitor Aug 9, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah, the message has to say "shouldn't". The test just ensures a panic case.

@Saitock Saitock Aug 9, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah, the message has to say "shouldn't". The test just ensures a panic case.

I will update it again when I get my computer 👍

@fee1-dead fee1-dead mentioned this pull request Aug 4, 2026
Open
12 tasks
@Saitock
Saitock requested a review from Lars-Schumann August 6, 2026 08:24
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 9, 2026
@rustbot

rustbot commented Aug 9, 2026

Copy link
Copy Markdown
Collaborator

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@Saitock

Saitock commented Aug 12, 2026

Copy link
Copy Markdown
Contributor Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 12, 2026
@JohnTitor

JohnTitor commented Aug 15, 2026

Copy link
Copy Markdown
Member

@bors squash

@rust-bors

This comment has been minimized.

Sign in to view
@Saitock
Update expect messages for library/alloc/src/vec/mod.rs
96aef28 
* Update expect messages for library/alloc/src/vec/mod.rs
* Update expect messages for library/alloctests/tests/vec.rs
* Update expect messages for library/alloc/src/vec/mod.rs and library/alloctests/tests/vec.rs
* Revert "Update expect messages for library/alloc/src/vec/mod.rs and library/alloctests/tests/vec.rs"

This reverts commit 009fa6f.
@rust-bors

rust-bors Bot commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

🔨 4 commits were squashed into 96aef28.

JohnTitor
JohnTitor approved these changes Aug 15, 2026
View reviewed changes

@JohnTitor JohnTitor left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! @bors r+

View changes since this review

@rust-bors

rust-bors Bot commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 96aef28 has been approved by JohnTitor

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 15, 2026
@JonathanBrouwer JonathanBrouwer mentioned this pull request Aug 15, 2026
Merged
rust-bors Bot pushed a commit that referenced this pull request Aug 15, 2026
@bors
Auto merge of #161134 - JonathanBrouwer:rollup-R2ewiX4, r=JonathanBro…
c9b7f17 
…uwer

Rollup of 5 pull requests

Successful merges:

 - #160203 (`Iterator::{min,max}(_by_key)` should use overridden `min`/`max`/`lt`)
 - #159862 (Update expect messages for library/alloc/src/vec/mod.rs)
 - #160719 (Improve OpenOptions append+truncate error message)
 - #160996 (Forward all array `PartialOrd` to slices)
 - #161102 (Explicitly pass run_make_support rlib/rmeta paths to compiletest)
@rust-bors
rust-bors Bot merged commit c095ceb into rust-lang:main Aug 15, 2026
13 checks passed
rust-bors Bot pushed a commit that referenced this pull request Aug 15, 2026
@bors
Unrolled build for #159862
db3c212 
Rollup merge of #159862 - Saitock:fix_expect, r=JohnTitor

Update expect messages for library/alloc/src/vec/mod.rs

Related issue: #159751
Updated some expect messages for `library/alloc/src/vec/mod.rs`
@rustbot rustbot added this to the 1.100.0 milestone Aug 15, 2026
rust-timer added a commit that referenced this pull request Aug 15, 2026
@rust-timer
Unrolled build for #159862
369655d 
Rollup merge of #159862 - Saitock:fix_expect, r=JohnTitor

Update expect messages for library/alloc/src/vec/mod.rs

Related issue: #159751
Updated some expect messages for `library/alloc/src/vec/mod.rs`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JohnTitor JohnTitor JohnTitor approved these changes
@Lars-Schumann Lars-Schumann Awaiting requested review from Lars-Schumann

Assignees

@JohnTitor JohnTitor

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.100.0

Development

Successfully merging this pull request may close these issues.

5 participants

@Saitock @rustbot @rust-log-analyzer @JohnTitor @Lars-Schumann