Use TyOrConstInferVar in the next solver, fix #158441 - #158436
Conversation
TyOrConstInferVar in the next solver, fix #158441
This comment has been minimized.
This comment has been minimized.
e5ea6c4 to
21f4f7a
Compare
21f4f7a to
b0372ea
Compare
This comment has been minimized.
This comment has been minimized.
b0372ea to
0662adb
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
0662adb to
ee595b6
Compare
This comment has been minimized.
This comment has been minimized.
9c1f34a to
0865dec
Compare
|
Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor Some changes occurred in need_type_info.rs cc @lcnr |
|
rustbot has assigned @petrochenkov. Use Why was this reviewer chosen?The reviewer was selected based on:
|
|
r? @lcnr |
This comment has been minimized.
This comment has been minimized.
Use `TyOrConstInferVar` in the next solver, fix #158441 This PR still has a couple percent improvement over main at time of writing (2026-08-10), as shown by the screenshot below. Rebased on #158447, should merge after since its technically required for correctness. Fixes #158441 <img width="1114" height="375" alt="image" src="https://github.com/user-attachments/assets/188a73d0-5987-48f3-923e-9883396bb1a3" /> > [!NOTE] > I've not used an LLM for any part of this PR, or any other PR I make. This includes any related work like research.
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
💔 Test for 300623f failed: CI. Failed job:
|
This comment has been minimized.
This comment has been minimized.
…try> Use `TyOrConstInferVar` in the next solver, fix #158441 try-job: aarch64-msvc-1
This comment has been minimized.
This comment has been minimized.
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing e64c8a6 (parent) -> 3d6c19b (this PR) Test differencesShow 28 test diffs28 doctest diffs were found. These are ignored, as they are noisy. Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 3d6c19bb9ab4798ecfb2ee943df01a811720fc27 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
Finished benchmarking commit (3d6c19b): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary 8.5%, secondary 2.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary 0.5%, secondary -0.9%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: 455.693s -> 455.92s (0.05%) |
View all comments
This PR still has a couple percent improvement over main at time of writing (2026-08-10), as shown by the screenshot below. Rebased on #158447, should merge after since its technically required for correctness.
Fixes #158441
Note
I've not used an LLM for any part of this PR, or any other PR I make. This includes any related work like research.