Skip to content

Use TyOrConstInferVar in the next solver, fix #158441 - #158436

Merged
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
jdonszelmann:fast-path-when-adding-goals
Aug 11, 2026
Merged

Use TyOrConstInferVar in the next solver, fix #158441#158436
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
jdonszelmann:fast-path-when-adding-goals

Conversation

@jdonszelmann

@jdonszelmann jdonszelmann commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

View all comments

This PR still has a couple percent improvement over main at time of writing (2026-08-10), as shown by the screenshot below. Rebased on #158447, should merge after since its technically required for correctness.

Fixes #158441

image

Note

I've not used an LLM for any part of this PR, or any other PR I make. This includes any related work like research.

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Jun 26, 2026
@jdonszelmann jdonszelmann changed the title TyOrConstInferVar next solver Use TyOrConstInferVar in the next solver, fix #158441 Jun 26, 2026
@rust-bors

This comment has been minimized.

@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jul 1, 2026
@jdonszelmann jdonszelmann reopened this Jul 1, 2026
@rustbot rustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jul 1, 2026
@jdonszelmann
jdonszelmann force-pushed the fast-path-when-adding-goals branch from e5ea6c4 to 21f4f7a Compare July 6, 2026 08:13
@rustbot rustbot added A-tidy Area: The tidy tool T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jul 6, 2026
@jdonszelmann
jdonszelmann force-pushed the fast-path-when-adding-goals branch from 21f4f7a to b0372ea Compare July 6, 2026 08:21
@rust-bors

This comment has been minimized.

@jdonszelmann
jdonszelmann force-pushed the fast-path-when-adding-goals branch from b0372ea to 0662adb Compare July 7, 2026 12:34
@rust-log-analyzer

This comment has been minimized.

@rust-bors

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@jdonszelmann
jdonszelmann force-pushed the fast-path-when-adding-goals branch 2 times, most recently from 9c1f34a to 0865dec Compare August 10, 2026 13:42
@jdonszelmann
jdonszelmann marked this pull request as ready for review August 10, 2026 13:42
@rustbot

rustbot commented Aug 10, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred to the core trait solver

cc @rust-lang/initiative-trait-system-refactor

Some changes occurred in need_type_info.rs

cc @lcnr

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 10, 2026
@rustbot

rustbot commented Aug 10, 2026

Copy link
Copy Markdown
Collaborator

r? @petrochenkov

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 75 candidates
  • Random selection from 18 candidates

@jdonszelmann

Copy link
Copy Markdown
Contributor Author

r? @lcnr

@rust-bors

rust-bors Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 57cac28 has been approved by lcnr

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 11, 2026
@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Aug 11, 2026
Use `TyOrConstInferVar` in the next solver, fix #158441



This PR still has a couple percent improvement over main at time of writing (2026-08-10), as shown by the screenshot below. Rebased on #158447, should merge after since its technically required for correctness.

Fixes #158441

<img width="1114" height="375" alt="image" src="https://github.com/user-attachments/assets/188a73d0-5987-48f3-923e-9883396bb1a3" />

> [!NOTE]
> I've not used an LLM for any part of this PR, or any other PR I make. This includes any related work like research.
@rust-log-analyzer

Copy link
Copy Markdown
Collaborator

The job aarch64-msvc-1 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
failures:

---- [debuginfo-cdb] tests\debuginfo\basic-stepping.rs#opt-level-0 stdout ----

error in revision `opt-level-0`: check directive(s) from `C:\a\rust\rust\tests\debuginfo\basic-stepping.rs#opt-level-0` not found in debugger output. errors:
    (basic-stepping.rs:130) `   [...]:     let i = [1,2,3,4];`
    (basic-stepping.rs:132) `   [...]:     let j = (23, "hi");`
    (basic-stepping.rs:134) `   [...]:     let k = 2..3;`
    (basic-stepping.rs:136) `   [...]:     let l = &i[k];`
    (basic-stepping.rs:138) `   [...]:     let m: *const() = &a;`
the following subset of check directive(s) was found successfully:
    (basic-stepping.rs:118) `>  147:     let mut c = 27;`
    (basic-stepping.rs:120) `>  148:     let d = c = 99;`
    (basic-stepping.rs:128) `>  152:     let h = ["whatever"; 8];`
status: exit code: 0
command: PATH="C:\a\rust\rust\build\aarch64-pc-windows-msvc\stage2\lib\rustlib\aarch64-pc-windows-msvc\lib;C:\Program Files (x86)\Windows Kits\10\bin\arm64;C:\Program Files (x86)\Windows Kits\10\bin\10.0.26100.0\arm64;C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.44.35207\bin\HostARM64\arm64;C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.44.35207\bin\HostARM64\arm64;C:\Program Files\Git\clangarm64\bin;C:\Program Files\Git\usr\bin;C:\Users\runneradmin\bin;C:\a\rust\rust\ninja;C:\a\rust\rust\citools\clang-rust\bin;C:\a\rust\rust\sccache;C:\aliyun-cli;C:\vcpkg;C:\tools\zstd;C:\Program Files (x86)\NSIS;C:\Program Files\Mercurial;C:\hostedtoolcache\windows\stack\3.11.1\x64;C:\mingw64\bin;C:\Program Files\dotnet;C:\Program Files\MySQL\MySQL Server 8.0\bin;C:\Program Files (x86)\R\R-4.6.1\bin\x64;C:\SeleniumWebDrivers\GeckoDriver;C:\SeleniumWebDrivers\EdgeDriver;C:\SeleniumWebDrivers\ChromeDriver;C:\Program Files (x86)\sbt\bin;C:\Program Files (x86)\GitHub CLI;C:\Program Files\Git\usr\bin;C:\Program Files (x86)\pipx_bin;C:\npm\prefix;C:\hostedtoolcache\windows\go\1.24.13\arm64\bin;C:\hostedtoolcache\windows\Python\3.13.14\arm64\Scripts;C:\hostedtoolcache\windows\Python\3.13.14\arm64;C:\hostedtoolcache\windows\Ruby\3.4.10\aarch64\bin;C:\Program Files\LLVM\bin;C:\Program Files\OpenSSL\bin;C:\tools\kotlinc\bin;C:\hostedtoolcache\windows\Java_Temurin-Hotspot_jdk\21.0.12-8.0\aarch64\bin;C:\Tools\Ninja;C:\Program Files (x86)\ImageMagick-7.1.2-Q16-HDRI;C:\Program Files\Microsoft SDKs\Azure\CLI2\wbin;C:\ProgramData\kind;C:\ProgramData\Chocolatey\bin;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0;C:\Windows\System32\OpenSSH;C:\Program Files\PowerShell\7;C:\Program Files\Microsoft\Web Platform Installer;C:\Program Files\Microsoft SQL Server\Client SDK\ODBC\170\Tools\Binn;C:\Program Files\Microsoft SQL Server\150\Tools\Binn;C:\Program Files\dotnet;C:\Program Files (x86)\Windows Kits\10\Windows Performance Toolkit;C:\Program Files\Microsoft SQL Server\130\DTS\Binn;C:\Program Files\Microsoft SQL Server\140\DTS\Binn;C:\Program Files\Microsoft SQL Server\150\DTS\Binn;C:\Program Files\Microsoft SQL Server\160\DTS\Binn;C:\Program Files\Microsoft SQL Server\170\DTS\Binn;C:\Strawberry\c\bin;C:\Strawberry\perl\site\bin;C:\Strawberry\perl\bin;C:\ProgramData\chocolatey\lib\pulumi\tools\Pulumi\bin;C:\Program Files\CMake\bin;C:\ProgramData\chocolatey\lib\maven\apache-maven-3.9.16\bin;C:\Program Files\nodejs;C:\Program Files\Git\cmd;C:\Program Files\Git\clangarm64\bin;C:\Program Files\Git\usr\bin;C:\Program Files\GitHub CLI;C:\tools\php;C:\Program Files (x86)\sbt\bin;C:\Program Files\Amazon\AWSCLIV2;C:\Program Files\Amazon\SessionManagerPlugin\bin;C:\Program Files\Amazon\AWSSAMCLI\bin;C:\Program Files\Microsoft SQL Server\130\Tools\Binn;C:\Users\runneradmin\.dotnet\tools;C:\Users\runneradmin\.cargo\bin;C:\Users\runneradmin\AppData\Local\Microsoft\WindowsApps" "C:\\Program Files (x86)\\Windows Kits\\10\\Debuggers\\arm64\\cdb.exe" "-lines" "-cf" "C:\\a\\rust\\rust\\build\\aarch64-pc-windows-msvc\\test\\debuginfo\\basic-stepping.opt-level-0.cdb\\basic-stepping.debugger.script" "C:\\a\\rust\\rust\\build\\aarch64-pc-windows-msvc\\test\\debuginfo\\basic-stepping.opt-level-0.cdb\\a.exe"
--- stdout -------------------------------

************* Preparing the environment for Debugger Extensions Gallery repositories **************
   ExtensionRepository : Implicit
   UseExperimentalFeatureForNugetShare : true
   AllowNugetExeUpdate : true
   NonInteractiveNuget : true
   AllowNugetMSCredentialProviderInstall : true
   AllowParallelInitializationOfLocalRepositories : true

   EnableRedirectToV8JsProvider : false

   -- Configuring repositories
      ----> Repository : LocalInstalled, Enabled: true
      ----> Repository : UserExtensions, Enabled: true

>>>>>>>>>>>>> Preparing the environment for Debugger Extensions Gallery repositories completed, duration 0.000 seconds

************* Waiting for Debugger Extensions Gallery to Initialize **************

>>>>>>>>>>>>> Waiting for Debugger Extensions Gallery to Initialize completed, duration 0.219 seconds
   ----> Repository : UserExtensions, Enabled: true, Packages count: 0
   ----> Repository : LocalInstalled, Enabled: true, Packages count: 27

Microsoft (R) Windows Debugger Version 10.0.26100.6584 ARM64
Copyright (c) Microsoft Corporation. All rights reserved.

CommandLine: C:\a\rust\rust\build\aarch64-pc-windows-msvc\test\debuginfo\basic-stepping.opt-level-0.cdb\a.exe

************* Path validation summary **************
Response                         Time (ms)     Location
Deferred                                       srv*
Symbol search path is: srv*
Executable search path is: 
ModLoad: 00007ff7`ad8a0000 00007ff7`ad8a7000   a.exe   
ModLoad: 00007ffa`653d0000 00007ffa`65807000   ntdll.dll
ModLoad: 00007ffa`63070000 00007ffa`631d9000   C:\Windows\System32\KERNEL32.DLL
ModLoad: 00007ffa`60b40000 00007ffa`61219000   C:\Windows\System32\KERNELBASE.dll
ModLoad: 00007ffa`602d0000 00007ffa`603d6000   C:\Windows\SYSTEM32\apphelp.dll
ModLoad: 00007ffa`60720000 00007ffa`60949000   C:\Windows\System32\ucrtbase.dll
ModLoad: 00007ffa`38430000 00007ffa`38523000   C:\a\rust\rust\build\aarch64-pc-windows-msvc\stage2\lib\rustlib\aarch64-pc-windows-msvc\lib\std-866f11ed616f593f.dll
ModLoad: 00007ffa`4a310000 00007ffa`4a34f000   C:\Windows\SYSTEM32\VCRUNTIME140.dll
ModLoad: 00007ffa`61e40000 00007ffa`61f16000   C:\Windows\System32\WS2_32.dll
ModLoad: 00007ffa`62de0000 00007ffa`62fe3000   C:\Windows\System32\RPCRT4.dll
ModLoad: 00007ffa`5ee80000 00007ffa`5eedf000   C:\Windows\SYSTEM32\USERENV.dll
ModLoad: 00007ffa`613e0000 00007ffa`614df000   C:\Windows\System32\bcryptprimitives.dll
(2224.1830): Break instruction exception - code 80000003 (first chance)
ntdll!LdrpDoDebuggerBreak+0x34:
00007ffa`6552d5a4 d43e0000 brk         #0xF000
0:000> version
Windows 10 Version 26200 MP (4 procs) Free ARM 64-bit (AArch64)
Product: WinNt, suite: SingleUserTS
Edition build lab: 26100.1.arm64fre.ge_release.240331-1435
Build layer: DesktopEditions -> 26100.1.arm64fre.ge_release.240331-1435
Build layer: OnecoreUAP -> 26100.1.arm64fre.ge_release.240331-1435
Build layer: ShellCommon -> 26100.8875.arm64fre.ge_release_svc_prod1.260710-1804
Build layer: OSClient   -> 26100.8875.arm64fre.ge_release_svc_prod1.260710-1804
Debug session time: Tue Aug 11 18:49:09.399 2026 (UTC + 0:00)
System Uptime: 0 days 1:48:59.538
Process Uptime: 0 days 0:00:01.377
  Kernel time: 0 days 0:00:00.000
  User time: 0 days 0:00:00.000
Live user mode: <Local>

Microsoft (R) Windows Debugger Version 10.0.26100.6584 ARM64
Copyright (c) Microsoft Corporation. All rights reserved.

command line: '"C:\Program Files (x86)\Windows Kits\10\Debuggers\arm64\cdb.exe" -lines -cf C:\a\rust\rust\build\aarch64-pc-windows-msvc\test\debuginfo\basic-stepping.opt-level-0.cdb\basic-stepping.debugger.script C:\a\rust\rust\build\aarch64-pc-windows-msvc\test\debuginfo\basic-stepping.opt-level-0.cdb\a.exe'  Debugger Process 0xFA4 
dbgeng:  image 10.0.26100.6584, 
        [path: C:\Program Files (x86)\Windows Kits\10\Debuggers\arm64\dbgeng.dll]
dbghelp: image 10.0.26100.7705, 
        [path: C:\Program Files (x86)\Windows Kits\10\Debuggers\arm64\dbghelp.dll]
        DIA version: 33145
Extension DLL search Path:
    C:\Program Files (x86)\Windows Kits\10\Debuggers\arm64\WINXP;C:\Program Files (x86)\Windows Kits\10\Debuggers\arm64\winext;C:\Program Files (x86)\Windows Kits\10\Debuggers\arm64\winext\arcade;C:\Program Files (x86)\Windows Kits\10\Debuggers\arm64\pri;C:\Program Files (x86)\Windows Kits\10\Debuggers\arm64;C:\Users\runneradmin\AppData\Local\Dbg\EngineExtensions;C:\Program Files (x86)\Windows Kits\10\Debuggers\arm64;C:\a\rust\rust\build\aarch64-pc-windows-msvc\stage2\lib\rustlib\aarch64-pc-windows-msvc\lib;C:\Program Files (x86)\Windows Kits\10\bin\arm64;C:\Program Files (x86)\Windows Kits\10\bin\10.0.26100.0\arm64;C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.44.35207\bin\HostARM64\arm64;C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.44.35207\bin\HostARM64\arm64;C:\Program Files\Git\clangarm64\bin;C:\Program Files\Git\usr\bin;C:\Users\runneradmin\bin;C:\a\rust\rust\ninja;C:\a\rust\rust\citools\clang-rust\bin;C:\a\rust\rust\sccache;C:\aliyun-cli;C:\vcpkg;C:\tools\zstd;C:\Program Files (x86)\NSIS;C:\Program Files\Mercurial;C:\hostedtoolcache\windows\stack\3.11.1\x64;C:\mingw64\bin;C:\Program Files\dotnet;C:\Program Files\MySQL\MySQL Server 8.0\bin;C:\Program Files (x86)\R\R-4.6.1\bin\x64;C:\SeleniumWebDrivers\GeckoDriver;C:\SeleniumWebDrivers\EdgeDriver;C:\SeleniumWebDrivers\ChromeDriver;C:\Program Files (x86)\sbt\bin;C:\Program Files (x86)\GitHub CLI;C:\Program Files\Git\usr\bin;C:\Program Files (x86)\pipx_bin;C:\npm\prefix;C:\hostedtoolcache\windows\go\1.24.13\arm64\bin;C:\hostedtoolcache\windows\Python\3.13.14\arm64\Scripts;C:\hostedtoolcache\windows\Python\3.13.14\arm64;C:\hostedtoolcache\windows\Ruby\3.4.10\aarch64\bin;C:\Program Files\LLVM\bin;C:\Program Files\OpenSSL\bin;C:\tools\kotlinc\bin;C:\hostedtoolcache\windows\Java_Temurin-Hotspot_jdk\21.0.12-8.0\aarch64\bin;C:\Tools\Ninja;C:\Program Files (x86)\ImageMagick-7.1.2-Q16-HDRI;C:\Program Files\Microsoft SDKs\Azure\CLI2\wbin;C:\ProgramData\kind;C:\ProgramData\Chocolatey\bin;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0;C:\Windows\System32\OpenSSH;C:\Program Files\PowerShell\7;C:\Program Files\Microsoft\Web Platform Installer;C:\Program Files\Microsoft SQL Server\Client SDK\ODBC\170\Tools\Binn;C:\Program Files\Microsoft SQL Server\150\Tools\Binn;C:\Program Files\dotnet;C:\Program Files (x86)\Windows Kits\10\Windows Performance Toolkit;C:\Program Files\Microsoft SQL Server\130\DTS\Binn;C:\Program Files\Microsoft SQL Server\140\DTS\Binn;C:\Program Files\Microsoft SQL Server\150\DTS\Binn;C:\Program Files\Microsoft SQL Server\160\DTS\Binn;C:\Program Files\Microsoft SQL Server\170\DTS\Binn;C:\Strawberry\c\bin;C:\Strawberry\perl\site\bin;C:\Strawberry\perl\bin;C:\ProgramData\chocolatey\lib\pulumi\tools\Pulumi\bin;C:\Program Files\CMake\bin;C:\ProgramData\chocolatey\lib\maven\apache-maven-3.9.16\bin;C:\Program Files\nodejs;C:\Program Files\Git\cmd;C:\Program Files\Git\clangarm64\bin;C:\Program Files\Git\usr\bin;C:\Program Files\GitHub CLI;C:\tools\php;C:\Program Files (x86)\sbt\bin;C:\Program Files\Amazon\AWSCLIV2;C:\Program Files\Amazon\SessionManagerPlugin\bin;C:\Program Files\Amazon\AWSSAMCLI\bin;C:\Program Files\Microsoft SQL Server\130\Tools\Binn;C:\Users\runneradmin\.dotnet\tools;C:\Users\runneradmin\.cargo\bin;C:\Users\runneradmin\AppData\Local\Microsoft\WindowsApps
Extension DLL chain:
    dbghelp: image 10.0.26100.7705, API 10.0.6, 
        [path: C:\Program Files (x86)\Windows Kits\10\Debuggers\arm64\dbghelp.dll]
    exts: image 10.0.26100.6584, API 1.0.0, 
        [path: C:\Program Files (x86)\Windows Kits\10\Debuggers\arm64\WINXP\exts.dll]
    uext: image 10.0.26100.6584, API 1.0.0, 
        [path: C:\Program Files (x86)\Windows Kits\10\Debuggers\arm64\winext\uext.dll]
    ntsdexts: image 10.0.26100.6584, API 1.0.0, 
        [path: C:\Program Files (x86)\Windows Kits\10\Debuggers\arm64\WINXP\ntsdexts.dll]
0:000> .nvlist
Loaded NatVis Files:
    <None Loaded>
0:000> bp `basic-stepping.rs:143`
*** WARNING: Unable to verify checksum for a.exe
*** WARNING: Unable to verify checksum for C:\a\rust\rust\build\aarch64-pc-windows-msvc\stage2\lib\rustlib\aarch64-pc-windows-msvc\lib\std-866f11ed616f593f.dll
0:000>  .lines -e
Line number information will be loaded
0:000>  l+s
Source options are 4:
     4/s - List source code at prompt
0:000>  l+t
Source options are 5:
     1/t - Step/trace by source line
     4/s - List source code at prompt
0:000>  g
Breakpoint 0 hit
>  147:     let mut c = 27;
a!basic_stepping::main+0x3c:
00007ff7`ad8a1118 52800368 mov         w8,#0x1B
0:000>  p
>  148:     let d = c = 99;
a!basic_stepping::main+0x44:
00007ff7`ad8a1120 52800c68 mov         w8,#0x63
0:000>  p
>  152:     let h = ["whatever"; 8];
a!basic_stepping::main+0x4c:
00007ff7`ad8a1128 9100a3e8 add         x8,sp,#0x28
0:000>  p
ModLoad: 00007ffa`5e4d0000 00007ffa`5e501000   C:\Windows\SYSTEM32\kernel.appcore.dll
ModLoad: 00007ffa`63350000 00007ffa`63498000   C:\Windows\System32\msvcrt.dll
ntdll!NtTerminateProcess+0x4:
00007ffa`653d1304 d65f03c0 ret
0:000>  p
        ^ No runnable debuggees error in ' p'
0:000>  p
        ^ No runnable debuggees error in ' p'
0:000>  p
        ^ No runnable debuggees error in ' p'
0:000>  p
        ^ No runnable debuggees error in ' p'
0:000>  p
        ^ No runnable debuggees error in ' p'
0:000> qq
quit:
NatVis script unloaded from 'C:\Program Files (x86)\Windows Kits\10\Debuggers\arm64\Visualizers\atlmfc.natvis'
NatVis script unloaded from 'C:\Program Files (x86)\Windows Kits\10\Debuggers\arm64\Visualizers\ObjectiveC.natvis'
NatVis script unloaded from 'C:\Program Files (x86)\Windows Kits\10\Debuggers\arm64\Visualizers\concurrency.natvis'
NatVis script unloaded from 'C:\Program Files (x86)\Windows Kits\10\Debuggers\arm64\Visualizers\cpp_rest.natvis'
NatVis script unloaded from 'C:\Program Files (x86)\Windows Kits\10\Debuggers\arm64\Visualizers\stl.natvis'
NatVis script unloaded from 'C:\Program Files (x86)\Windows Kits\10\Debuggers\arm64\Visualizers\Windows.Data.Json.natvis'
NatVis script unloaded from 'C:\Program Files (x86)\Windows Kits\10\Debuggers\arm64\Visualizers\Windows.Devices.Geolocation.natvis'
NatVis script unloaded from 'C:\Program Files (x86)\Windows Kits\10\Debuggers\arm64\Visualizers\Windows.Devices.Sensors.natvis'
NatVis script unloaded from 'C:\Program Files (x86)\Windows Kits\10\Debuggers\arm64\Visualizers\Windows.Media.natvis'
NatVis script unloaded from 'C:\Program Files (x86)\Windows Kits\10\Debuggers\arm64\Visualizers\windows.natvis'
NatVis script unloaded from 'C:\Program Files (x86)\Windows Kits\10\Debuggers\arm64\Visualizers\winrt.natvis'
------------------------------------------
stderr: none

---- [debuginfo-cdb] tests\debuginfo\basic-stepping.rs#opt-level-0 stdout end ----

failures:
    [debuginfo-cdb] tests\debuginfo\basic-stepping.rs#opt-level-0

test result: FAILED. 165 passed; 1 failed; 353 ignored; 0 measured; 0 filtered out; finished in 41.41s

Some tests failed in compiletest suite=debuginfo mode=debuginfo host=aarch64-pc-windows-msvc target=aarch64-pc-windows-msvc
Bootstrap failed while executing `test --stage 2 --skip=compiler --skip=src --skip=src/tools/linkchecker`
Currently active steps:
test::Debuginfo { test_compiler: Compiler { stage: 2, host: aarch64-pc-windows-msvc, forced_compiler: false }, target: aarch64-pc-windows-msvc } at src\bootstrap\src\core\build_steps\test.rs:1953
test::Compiletest { test_compiler: Compiler { stage: 2, host: aarch64-pc-windows-msvc, forced_compiler: false }, target: aarch64-pc-windows-msvc, mode: debuginfo, suite: "debuginfo", path: "tests/debuginfo", compare_mode: Some("split-dwarf") } at src\bootstrap\src\core\build_steps\test.rs:1953
Build completed unsuccessfully in 1:21:35
make: *** [Makefile:115: ci-msvc-py] Error 1
  local time: Tue Aug 11 18:49:48 CUT 2026
  network time: Tue, 11 Aug 2026 18:49:49 GMT
##[error]Process completed with exit code 2.
##[group]Run echo "disk usage:"
echo "disk usage:"

@rust-bors rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 11, 2026
@rust-bors

rust-bors Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

💔 Test for 300623f failed: CI. Failed job:

@JonathanBrouwer

Copy link
Copy Markdown
Contributor

Probably spurious
@bors retry
@bors try jobs=aarch64-msvc-1

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 11, 2026
@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Aug 11, 2026
…try>

Use `TyOrConstInferVar` in the next solver, fix #158441


try-job: aarch64-msvc-1
@rust-bors

This comment has been minimized.

@rust-bors

rust-bors Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 23b1229 (23b12296e21b28b990b9a85b5dc1c93c352188c4)
Base parent: e64c8a6 (e64c8a664d9da54fc239cd4404cbf67f0d624326)

@rust-bors rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 11, 2026
@rust-bors

rust-bors Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

☀️ Test successful - CI
Approved by: lcnr
Duration: 3h 16m 19s
Pushing 3d6c19b to main...

@github-actions

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing e64c8a6 (parent) -> 3d6c19b (this PR)

Test differences

Show 28 test diffs

28 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 3d6c19bb9ab4798ecfb2ee943df01a811720fc27 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-gnu-debug: 1h 8m -> 1h 53m (+65.8%)
  2. x86_64-mingw-1: 2h 2m -> 2h 57m (+44.6%)
  3. dist-x86_64-apple: 2h 32m -> 1h 32m (-39.7%)
  4. x86_64-msvc-1: 1h 55m -> 2h 38m (+36.7%)
  5. x86_64-rust-for-linux: 34m 9s -> 45m 56s (+34.5%)
  6. test-various: 1h 45m -> 1h 14m (-30.0%)
  7. x86_64-gnu-llvm-22-2: 1h 7m -> 1h 25m (+27.8%)
  8. dist-i686-linux: 1h 23m -> 1h 47m (+27.8%)
  9. dist-x86_64-musl: 2h 10m -> 1h 34m (-27.4%)
  10. pr-check-1: 30m 9s -> 22m 5s (-26.7%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (3d6c19b): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.3% [0.3%, 0.3%] 3
Improvements ✅
(primary)
-0.2% [-0.3%, -0.1%] 6
Improvements ✅
(secondary)
-1.2% [-2.7%, -0.2%] 37
All ❌✅ (primary) -0.2% [-0.3%, -0.1%] 6

Max RSS (memory usage)

Results (primary 8.5%, secondary 2.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
8.5% [8.5%, 8.5%] 1
Regressions ❌
(secondary)
2.2% [0.4%, 13.0%] 10
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.7% [-0.7%, -0.7%] 1
All ❌✅ (primary) 8.5% [8.5%, 8.5%] 1

Cycles

Results (primary 0.5%, secondary -0.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
2.0% [1.7%, 2.4%] 2
Regressions ❌
(secondary)
0.9% [0.4%, 2.7%] 9
Improvements ✅
(primary)
-2.6% [-2.6%, -2.6%] 1
Improvements ✅
(secondary)
-1.6% [-5.2%, -0.4%] 21
All ❌✅ (primary) 0.5% [-2.6%, 2.4%] 3

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 455.693s -> 455.92s (0.05%)
Artifact size: 396.39 MiB -> 396.47 MiB (0.02%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-tidy Area: The tidy tool merged-by-bors This PR was explicitly merged by bors. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

old solver keeps goals stalled even if their infer vars change

7 participants