Move distributed std's profile settings to its workspace - #158264
Open
adamgemmell wants to merge 8 commits into
Open
Move distributed std's profile settings to its workspace#158264adamgemmell wants to merge 8 commits into
adamgemmell wants to merge 8 commits into
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
View all comments
The configuration used by std needs to be moved to somewhere the new build-std can see it. This PR moves settings that Cargo can model in its profile to the dist profile and ensures that bootstrap does not try to override them.
This PR adds a new Mode, DistStd, to bootstrap, as proposed by @Kobzol a while ago, which is used when building the standard library during
x distbuilds. This mode:distprofile in the library workspace, added in Move bootstrap configuration to library workspace #149514Note that RUSTFLAGS can still be set based on configuration, and this will be addressed in an upcoming patch as we still need to work out how build-std can consume target-specific configuration. Probably this will go in the cargo config.