Put internal lints into a single combined pass - #158056
Merged
Merged
Conversation
This makes it consistent with the other late internal lints. It doesn't need to be a crate-level pass because it doesn't implement `check_crate` or `check_crate_post` and/or track any crate-level information.
Instead of N separate passes. This is more efficient for bootstrapping. It also matches what is done for builtin lints (`BuiltinCombined*LintPass`).
rustbot
added
S-waiting-on-review
Contributor
Author
|
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
rustbot
added
the
S-waiting-on-perf
rust-bors Bot
pushed a commit
that referenced
this pull request
Jun 18, 2026
Put internal lints into a single combined pass
Contributor
This comment has been minimized.
This comment has been minimized.
Collaborator
|
Finished benchmarking commit (3481834): comparison URL. Overall result: no relevant changes - no action neededBenchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up. @rustbot label: -S-waiting-on-perf -perf-regression Instruction countThis perf run didn't have relevant results for this metric. Max RSS (memory usage)Results (primary -5.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary 22.6%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: 522.85s -> 520.933s (-0.37%) |
rustbot
removed
the
S-waiting-on-perf
Contributor
Author
|
The only perf effect this might have had was speeding up bootstrap. The CI run suggests not much happened there -- any effect is below the noise threshold. Still worth merging from a consistency standpoint, I think. |
Member
|
@bors r+ |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jun 18, 2026
Put internal lints into a single combined pass Details in individual commits. r? @Urgau
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jun 18, 2026
Put internal lints into a single combined pass Details in individual commits. r? @Urgau
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jun 18, 2026
Put internal lints into a single combined pass Details in individual commits. r? @Urgau
rust-bors Bot
pushed a commit
that referenced
this pull request
Jun 18, 2026
Rollup of 8 pull requests Successful merges: - #158056 (Put internal lints into a single combined pass) - #151132 (Take care to use MSG_EOR with SOCK_SEQPACKET sockets) - #157644 (wasm32-wasip1-threads: Correct llvm target name) - #157912 (stabilize str_from_utf16_endian) - #158048 (Revert "add regression test for Redundant memory strores with mut parameters in by-value returns") - #158051 (Document `with_added_extension` edge cases) - #158054 (fix unresolved import suggestion before outer attributes) - #158062 (rustc book: Update wasm32-wasip1-threads's maintainers list)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details in individual commits.
r? @Urgau