Allow running x <cmd> <path> from a different directory - #146774
Merged
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
|
jieyouxu
approved these changes
Sep 20, 2025
Member
|
Thanks |
Collaborator
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Sep 20, 2025
…jieyouxu Allow running `x <cmd> <path>` from a different directory Fixes: rust-lang#146772 r? `@jieyouxu`
bors
added a commit
that referenced
this pull request
Sep 20, 2025
Rollup of 6 pull requests Successful merges: - #144592 (generate list of all variants with `target_spec_enum`) - #146762 (Fix and provide instructions for running test suite on Apple simulators) - #146766 (Add attributes for #[global_allocator] functions) - #146770 (fixes for numerous clippy warnings) - #146774 (Allow running `x <cmd> <path>` from a different directory) - #146800 (Fix unsupported `std::sys::thread` after move) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
that referenced
this pull request
Sep 20, 2025
Rollup of 5 pull requests Successful merges: - #144592 (generate list of all variants with `target_spec_enum`) - #146762 (Fix and provide instructions for running test suite on Apple simulators) - #146770 (fixes for numerous clippy warnings) - #146774 (Allow running `x <cmd> <path>` from a different directory) - #146800 (Fix unsupported `std::sys::thread` after move) r? `@ghost` `@rustbot` modify labels: rollup
Contributor
|
@bors r- already merged but still in the queue |
bors
added
S-waiting-on-author
github-actions Bot
pushed a commit
to rust-lang/rustc-dev-guide
that referenced
this pull request
Sep 22, 2025
Rollup of 5 pull requests Successful merges: - rust-lang/rust#144592 (generate list of all variants with `target_spec_enum`) - rust-lang/rust#146762 (Fix and provide instructions for running test suite on Apple simulators) - rust-lang/rust#146770 (fixes for numerous clippy warnings) - rust-lang/rust#146774 (Allow running `x <cmd> <path>` from a different directory) - rust-lang/rust#146800 (Fix unsupported `std::sys::thread` after move) r? `@ghost` `@rustbot` modify labels: rollup
Muscraft
pushed a commit
to Muscraft/rust
that referenced
this pull request
Sep 24, 2025
…jieyouxu Allow running `x <cmd> <path>` from a different directory Fixes: rust-lang#146772 r? ``@jieyouxu``
Muscraft
pushed a commit
to Muscraft/rust
that referenced
this pull request
Sep 24, 2025
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#144592 (generate list of all variants with `target_spec_enum`) - rust-lang#146762 (Fix and provide instructions for running test suite on Apple simulators) - rust-lang#146770 (fixes for numerous clippy warnings) - rust-lang#146774 (Allow running `x <cmd> <path>` from a different directory) - rust-lang#146800 (Fix unsupported `std::sys::thread` after move) r? `@ghost` `@rustbot` modify labels: rollup
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Aug 11, 2026
bootstrap: Simplify absolute path handling The existing code takes a command-line argument (that might not even be a path), glues it to the repository path, makes it absolute relative to the working directory, then tries to strip the repository path off again. That all seems needlessly complicated. The new approach is much simpler: If an argument is an absolute path that exists, try to strip the repository path from it, or otherwise change nothing. That should hopefully give the same results in every useful case. --- Relevant earlier PRs: - rust-lang#126782 - rust-lang#146774 r? Kobzol (who last modified this code), or bootstrap
rust-timer
added a commit
that referenced
this pull request
Aug 11, 2026
Rollup merge of #160855 - Zalathar:absolute, r=Kobzol bootstrap: Simplify absolute path handling The existing code takes a command-line argument (that might not even be a path), glues it to the repository path, makes it absolute relative to the working directory, then tries to strip the repository path off again. That all seems needlessly complicated. The new approach is much simpler: If an argument is an absolute path that exists, try to strip the repository path from it, or otherwise change nothing. That should hopefully give the same results in every useful case. --- Relevant earlier PRs: - #126782 - #146774 r? Kobzol (who last modified this code), or bootstrap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #146772
r? @jieyouxu