Skip to content

miri: disable test_downgrade_observe test on macOS#133435

Merged
bors merged 1 commit into
rust-lang:masterfrom
RalfJung:test_downgrade_observe
Nov 27, 2024
Merged

miri: disable test_downgrade_observe test on macOS#133435
bors merged 1 commit into
rust-lang:masterfrom
RalfJung:test_downgrade_observe

Conversation

@RalfJung

Copy link
Copy Markdown
Member

Due to #121950, this test can fail on Miri. The test is also quite slow on Miri (taking more than 30s) due to the high iteration count (a total of 2000), so let's reduce that a little.

Fixes #133421

@rustbot

rustbot commented Nov 25, 2024

Copy link
Copy Markdown
Collaborator

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 25, 2024
@tgross35

Copy link
Copy Markdown
Contributor

Makes sense, this is consistent with #133200.

@bors r+

@bors

bors commented Nov 25, 2024

Copy link
Copy Markdown
Collaborator

📌 Commit c9b56b9 has been approved by tgross35

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 25, 2024
@bors bors merged commit c4e2b0c into rust-lang:master Nov 27, 2024
@rustbot rustbot added this to the 1.85.0 milestone Nov 27, 2024
@RalfJung RalfJung deleted the test_downgrade_observe branch November 28, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Spurious miri library rwlock test failure?

4 participants