Don't delay a bug if we suggest adding a semicolon to the RHS of an assign operator

[compiler-errors]

It only makes sense to delay a bug based on the assumption that "[we] defer to the later error produced by check_lhs_assignable" if the expression we're erroring actually is an LHS; otherwise, we should still report the error since it's both useful and required.

Fixes #123722

[rustbot]

r? @wesleywiser

rustbot has assigned @wesleywiser.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[compiler-errors]

r? @estebank since you touched this in 4b7aaca

[estebank]

@bors r+

[bors]

📌 Commit 889ca7e has been approved by estebank

It is now in the queue for this repository.

[bors]

⌛ Testing commit 889ca7e with merge ab71ee7...

[bors]

☀️ Test successful - checks-actions
Approved by: estebank
Pushing ab71ee7 to master...

[rust-timer]

Finished benchmarking commit (ab71ee7): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	4.3%	[4.3%, 4.3%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.0%	[-3.0%, -3.0%]	1
All ❌✅ (primary)	4.3%	[4.3%, 4.3%]	1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-3.4%	[-4.7%, -2.5%]	13
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-3.4%	[-4.7%, -2.5%]	13

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 676.794s -> 676.395s (-0.06%)
Artifact size: 316.09 MiB -> 316.00 MiB (-0.03%)