Bootstrap bump

[Mark-Simulacrum]

Bumps bootstrap compiler to just-released beta.

https://forge.rust-lang.org/release/process.html#master-bootstrap-update-t-2-day-tuesday

[rustbot]

r? @clubby789

(rustbot has picked a reviewer for you, use r? to override)

[Mark-Simulacrum]

rustfmt changes seem potentially more widespread than I'd expect, so asked on Zulip about them - https://rust-lang.zulipchat.com/#narrow/stream/266220-t-rustdoc/topic/expected.20changes.20in.20bootstrap.20bump.3F

cc @rust-lang/rustdoc as well

[Mark-Simulacrum]

er, @rust-lang/rustfmt, sorry

[calebcartwright]

rustfmt changes seem potentially more widespread than I'd expect, so asked on Zulip about them - https://rust-lang.zulipchat.com/#narrow/stream/266220-t-rustdoc/topic/expected.20changes.20in.20bootstrap.20bump.3F

cc @rust-lang/rustdoc as well

Acknowledge seeing this, from a quick glance many of the changes look related to things like the newly added support for formatting let chains (some of the diffs are to lines contained within the body of a let chain). Can take a deeper look later though

[GuillaumeGomez]

Please don't add the link to the rustdoc team in your replies. We get re-subscribed every time. 😅

[Urgau]

The job x86_64-gnu-llvm-15 failed! Check out the build log: (web) (plain)
Click to see the possible cause of the failure (guessed by this bot)

I've investigated the failure. This due to the way the cranelift build system and bootstrap interacts.
bootstrap use RUSTFLAGS to pass extra --check-cfg arguments which the cranelift build system happily passes, marking some cfgs (bootstrap and parallel_compiler) as expected.
This didn't cause a issue before because cranelift build system didn't respect -Zcheck-cfg that we were passing to Cargo, but now with the new syntax, exhaustiveness is by default, making no_unstable_features unexpected.

The short term solution would be to add it the our list of EXTRA_CHECK_CFG in bootstrap.
The long term solution is a bit unclear, either cranelift build system should mark no_unstable_features as expected or maybe not re-use the RUSTFLAGS from bootstrap.
Tagging @bjorn3 for awareness.

[bjorn3]

cg_clif's build system has to respect RUSTFLAGS to pick up the right linker and such. I can add -Zcheck-cfg= to it though.

[Urgau]

cg_clif's build system has to respect RUSTFLAGS to pick up the right linker and such. I can add -Zcheck-cfg= to it though.

Adding --check-cfg=cfg(no_unstable_features) to every rustc invocation for mini_core should do it.

[bjorn3]

Adding that here should work:

rust/compiler/rustc_codegen_cranelift/build_system/tests.rs

Line 459 in d97bb19

cmd.arg("-Cpanic=abort");

[rustbot]

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

[Mark-Simulacrum]

@bors r-

[Mark-Simulacrum]

@bors r=clubby789

[bors]

📌 Commit 9e8edb6 has been approved by clubby789

It is now in the queue for this repository.

[bors]

⌛ Testing commit 9e8edb6 with merge 1be1e84...

[bors]

☀️ Test successful - checks-actions
Approved by: clubby789
Pushing 1be1e84 to master...

[rust-timer]

Finished benchmarking commit (1be1e84): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.3%	[0.9%, 1.8%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.9%	[-1.3%, -0.5%]	3
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.0%	[-1.3%, 1.8%]	5

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.9%	[-2.1%, -1.8%]	2
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 675.207s -> 676.569s (0.20%)
Artifact size: 313.64 MiB -> 313.63 MiB (-0.00%)

[chenrui333]

• for what is worth, it has fixed [homebrew] rust 1.73.0 failed to build on 12-arm #117299