Skip to content

Rustup rust-lang/rust#66188#4795

Merged
bors merged 2 commits into
rust-lang:masterfrom
HMPerson1:rustup
Nov 8, 2019
Merged

Rustup rust-lang/rust#66188#4795
bors merged 2 commits into
rust-lang:masterfrom
HMPerson1:rustup

Conversation

@HMPerson1

@HMPerson1 HMPerson1 commented Nov 8, 2019

Copy link
Copy Markdown
Contributor

changelog: none

matthiaskrgr
matthiaskrgr approved these changes Nov 8, 2019
View reviewed changes

@matthiaskrgr matthiaskrgr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bors r+
thanks!

@matthiaskrgr

matthiaskrgr commented Nov 8, 2019

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Nov 8, 2019

Copy link
Copy Markdown
Contributor

📌 Commit 94b36d9 has been approved by matthiaskrgr

@bors

bors commented Nov 8, 2019

Copy link
Copy Markdown
Contributor

⌛ Testing commit 94b36d9 with merge d480273...

bors added a commit that referenced this pull request Nov 8, 2019
@bors
Auto merge of #4795 - HMPerson1:rustup, r=matthiaskrgr
d480273 
Rustup rust-lang/rust#66188

changelog: none
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 8, 2019
Closed
@bors

bors commented Nov 8, 2019

Copy link
Copy Markdown
Contributor

💔 Test failed - checks-travis

@flip1995

flip1995 commented Nov 8, 2019

Copy link
Copy Markdown
Member

@bors retry p=10 (weird osx error)

@bors

bors commented Nov 8, 2019

Copy link
Copy Markdown
Contributor

⌛ Testing commit 94b36d9 with merge 37fa1e2...

bors added a commit that referenced this pull request Nov 8, 2019
@bors
Auto merge of #4795 - HMPerson1:rustup, r=matthiaskrgr
37fa1e2 
Rustup rust-lang/rust#66188

changelog: none
@flip1995

flip1995 commented Nov 8, 2019

Copy link
Copy Markdown
Member

@bors treeclose=10

There are currently 3 more PRs in queue. (it's treeclose-, not treeclosed- to open up the queue again, BTW)

@flip1995

flip1995 commented Nov 8, 2019

Copy link
Copy Markdown
Member

@bors treeclosed=10

@flip1995

flip1995 commented Nov 8, 2019

Copy link
Copy Markdown
Member

But to actually close the tree you have to write treeclosed? 🤔

@matthiaskrgr

matthiaskrgr commented Nov 8, 2019

Copy link
Copy Markdown
Member

Hm, it should be treeclose according to the page https://buildbot2.rust-lang.org/homu/ 🤔

@flip1995

flip1995 commented Nov 8, 2019

Copy link
Copy Markdown
Member

It actually is treeclosed for both. See source code: https://github.com/rust-lang/homu/blob/1e0041c8f6db6500dbc587cf581597092b130cea/homu/parse_issue_comment.py#L246

@flip1995 flip1995 mentioned this pull request Nov 8, 2019
Merged
@bors

bors commented Nov 8, 2019

Copy link
Copy Markdown
Contributor

☀️ Test successful - checks-travis, status-appveyor
Approved by: matthiaskrgr
Pushing 37fa1e2 to master...

@bors bors merged commit 94b36d9 into rust-lang:master Nov 8, 2019
@flip1995

flip1995 commented Nov 8, 2019

Copy link
Copy Markdown
Member

@bors treeclosed-

@flip1995

flip1995 commented Nov 8, 2019

Copy link
Copy Markdown
Member

@bors are you still there?

@flip1995

flip1995 commented Nov 8, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

Is it possible, that bors doesn't fetches closed PRs and you have to open the tree in an open PR?

cc #4776 (comment)

@mati865

mati865 commented Nov 8, 2019

Copy link
Copy Markdown
Member

@flip1995 it's exactly the case.

@HMPerson1 HMPerson1 deleted the rustup branch November 9, 2019 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matthiaskrgr matthiaskrgr matthiaskrgr approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@HMPerson1 @matthiaskrgr @bors @flip1995 @mati865