Use diagnostic item for Vec#4519
Merged
Merged
Conversation
Contributor
Author
|
cc @oli-obk |
oli-obk
approved these changes
Sep 7, 2019
Contributor
Author
|
This fails because the item doesn't match. I probably should use the |
Contributor
|
If there's no symbol in the sym list, you can call Symbol::intern("vec_type") At least I think there's a function called intern. As long as you don't use gensym, any way to create the symbol should be fine |
llogiq
force-pushed
the
vec-diagnostic-item
branch
from
September 7, 2019 14:46
582fc66 to
0a78316
Compare
llogiq
marked this pull request as ready for review
September 7, 2019 14:47
Contributor
Author
|
I left a few positions where either the paths were part of a slice of paths or the function would have needed a larger refactoring. |
Contributor
Author
|
Error seems unrelated. Do we need a rustup? |
Member
oli-obk
approved these changes
Sep 8, 2019
llogiq
force-pushed
the
vec-diagnostic-item
branch
from
September 9, 2019 03:43
0a78316 to
e3c4ffd
Compare
Contributor
Author
|
Rebased |
Contributor
Author
Contributor
|
📌 Commit e3c4ffd has been approved by |
Contributor
bors
added a commit
that referenced
this pull request
Sep 9, 2019
Use diagnostic item for `Vec` This adds a new `is_type_diagnostic_item` to check items without lookup via `match_type`. changelog: none
Contributor
|
☀️ Test successful - checks-travis, status-appveyor |
Contributor
|
Should we have a tracking issue of some sort for the different diagnostic items? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new
is_type_diagnostic_itemto check items without lookup viamatch_type.changelog: none