Rename unecessary_nonzero_get to needless_nonzero_get - #17538
Merged
Conversation
rustbot
added
needs-fcp
Collaborator
|
|
samueltardieu
requested changes
Aug 11, 2026
rustbot
added
S-waiting-on-author
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
Gri-ffin
force-pushed
the
rename_unecessary_nonzero_get
branch
from
August 11, 2026 19:29
51110b7 to
7c10243
Compare
Contributor
Author
|
@rustbot ready |
rustbot
added
S-waiting-on-review
Contributor
Author
|
should I then drop the changelog in the pr description? |
Member
Just add "same release” to it. |
samueltardieu
approved these changes
Aug 11, 2026
Member
There was a problem hiding this comment.
You can merge it after the changelog has been updated.
@rustbot delegate
Collaborator
|
✌️ @Gri-ffin, you can now merge this pull request! If @samueltardieu told you to merge after making some further change, then please make that change and post |
Contributor
Author
|
@rustbot merge |
rustbot
removed
the
S-waiting-on-review
This was referenced Aug 11, 2026
This was referenced Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: #t-clippy/fcp > FCP rust-clippy#17499: New lint/nonzero operators and metho…
r? @samueltardieu
changelog: [
unnecessary_nonzero_get]: rename toneedless_nonzero_get(same release)