New lint: unused underscore prefixed argument

[clueless-skywatcher]

• Followed [lint naming conventions][lint_naming]
• Added passing UI tests (including committed .stderr file)
• cargo test passes locally
• Executed cargo dev update_lints
• Added lint documentation
• Run cargo dev fmt

---

changelog: [unused_underscore_prefixed_argument]: add lint

[rustbot]

Thanks for the pull request, and welcome!

You should hear from one of our reviewers after this PR gets at least 2 reviews from the community.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

• @rustbot author: the review is finished, PR author should check the comments and take action accordingly
• @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

[github-actions]

Lintcheck changes for ac2a18e

Lint	Added	Removed	Changed
clippy::unused_underscore_prefixed_argument	135	0	0

This comment will be updated if you push new changes

[DanielEScherzer]

Community review: the second new added report given in lintcheck is for https://docs.rs/backtrace/0.3.73/src/backtrace/symbolize/gimli/libs_dl_iterate_phdr.rs.html#42 - this exactly highlights what I was worried about: the signature of the function comes from being passed as a pointer to https://docs.rs/libc/0.2.186/libc/fn.dl_iterate_phdr.html

a few reports later is https://docs.rs/bytes/1.6.1/src/bytes/bytes.rs.html#1146 - this signature comes from being stored in a function pointer field, https://docs.rs/bytes/1.6.1/src/bytes/bytes.rs.html#118

I didn't check all of the hits, but at least some of these are places where the lint is problematic

Maybe start by excluding anything marked as extern ?

View changes since this review

[Gri-ffin]

@rustbot author

[rustbot]

Reminder, once the PR becomes ready for a review, use @rustbot ready.

[rustbot]

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

[rustbot]

⚠️ Warning ⚠️

• The following commits have merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged.

  • 7b4041b
  • 9e8b983
  • c7c8324

  You can start a rebase with the following commands:

  $ # rebase
  $ git pull --rebase https://github.com/rust-lang/rust-clippy.git master
  $ git push --force-with-lease
  

[rustbot]

☔ The latest upstream changes (possibly #17552) made this pull request unmergeable. Please resolve the merge conflicts.