Skip to content

Add split_filter_map_ok lint - #16763

Open
vitkyrka wants to merge 1 commit into
rust-lang:masterfrom
vitkyrka:split
Open

Add split_filter_map_ok lint#16763
vitkyrka wants to merge 1 commit into
rust-lang:masterfrom
vitkyrka:split

Conversation

@vitkyrka

@vitkyrka vitkyrka commented Mar 26, 2026

Copy link
Copy Markdown

Add a new lint identical to lines_filter_map_ok except that it checks for std::io::Split instead of std::io::Lines.


changelog: [split_filter_map_ok]: add lint

@rustbot rustbot added the needs-fcp PRs that add, remove, or rename lints and need an FCP label Apr 7, 2026
@vitkyrka vitkyrka changed the title Extend lines_filter_map_ok to catch split() too New lint: split_filter_map_ok Apr 7, 2026
@vitkyrka vitkyrka changed the title New lint: split_filter_map_ok Add split_filter_map_ok lint Apr 7, 2026
@vitkyrka
vitkyrka marked this pull request as ready for review April 7, 2026 14:23
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 7, 2026
@rustbot

rustbot commented Apr 7, 2026

Copy link
Copy Markdown
Collaborator

r? @samueltardieu

rustbot has assigned @samueltardieu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: 7 candidates
  • 7 candidates expanded to 7 candidates
  • Random selection from Jarcho, dswij, llogiq, samueltardieu

@rustbot

This comment has been minimized.

@rustbot

rustbot commented May 11, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@rustbot

rustbot commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (possibly #17552) made this pull request unmergeable. Please resolve the merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-fcp PRs that add, remove, or rename lints and need an FCP S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants