Lint comparison to empty slice using PartialEq methods#13432
Merged
Conversation
Collaborator
|
r? @Manishearth rustbot has assigned @Manishearth. Use |
rustbot
added
the
S-waiting-on-review
GuillaumeGomez
approved these changes
Sep 22, 2024
GuillaumeGomez
left a comment
GuillaumeGomez
left a comment
Member
There was a problem hiding this comment.
Looks good to me, thanks! (still needs someone from the team to r+ it)
Contributor
|
☔ The latest upstream changes (presumably #13440) made this pull request unmergeable. Please resolve the merge conflicts. |
samueltardieu
force-pushed
the
issue-13401
branch
from
September 22, 2024 19:29
c03be67 to
acff511
Compare
Manishearth
approved these changes
Sep 22, 2024
Member
Author
|
@Manishearth Did you forget to r+ it by chance? |
Member
|
I think there was something else going on but it's not relevant anymore @bors r+ |
Contributor
Contributor
Contributor
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changelog: [
comparison_to_empty]: Also detect comparaisons usingPartialEqmethodsFix #13401