Skip to content

Split def_path_res into two parts#13431

Merged
bors merged 2 commits into
rust-lang:masterfrom
GnomedDev:split-def_path_res
Sep 23, 2024
Merged

Split def_path_res into two parts#13431
bors merged 2 commits into
rust-lang:masterfrom
GnomedDev:split-def_path_res

Conversation

@GnomedDev

Copy link
Copy Markdown
Contributor

def_path_res previously had two jobs:

  1. looking up the crates to find the path in
  2. looking up path in said crates

This splits that job up into two functions, keeping def_path_res as an adapter between the both, to avoid repeating the first step when repeatedly looking up items in the same crate.

changelog: none

@rustbot

rustbot commented Sep 21, 2024

Copy link
Copy Markdown
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @y21 (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 21, 2024
@bors

bors commented Sep 22, 2024

Copy link
Copy Markdown
Contributor

☔ The latest upstream changes (presumably #13440) made this pull request unmergeable. Please resolve the merge conflicts.

Comment thread clippy_utils/src/lib.rs Outdated
Comment thread clippy_utils/src/paths.rs Outdated
@y21

y21 commented Sep 23, 2024

Copy link
Copy Markdown
Member

Thanks!

@bors r+

@bors

bors commented Sep 23, 2024

Copy link
Copy Markdown
Contributor

📌 Commit 6b34c8d has been approved by y21

It is now in the queue for this repository.

@bors

bors commented Sep 23, 2024

Copy link
Copy Markdown
Contributor

⌛ Testing commit 6b34c8d with merge 8ab744e...

@bors

bors commented Sep 23, 2024

Copy link
Copy Markdown
Contributor

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: y21
Pushing 8ab744e to master...

@bors
bors merged commit 8ab744e into rust-lang:master Sep 23, 2024
@GnomedDev
GnomedDev deleted the split-def_path_res branch September 24, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants