Skip to content

[mem_replace_with_default] No longer triggers on unused expression#12278

Merged
bors merged 1 commit into
rust-lang:masterfrom
GabrielBFern:master
Feb 13, 2024
Merged

[mem_replace_with_default] No longer triggers on unused expression#12278
bors merged 1 commit into
rust-lang:masterfrom
GabrielBFern:master

Conversation

@GabrielBFern

Copy link
Copy Markdown
Contributor

changelog:[mem_replace_with_default]: No longer triggers on unused expression

Change [mem_replace_with_default] to not trigger on unused expression because the lint from #[must_use] handle this case better.

fixes: #5586

@rustbot

rustbot commented Feb 12, 2024

Copy link
Copy Markdown
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Jarcho (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Feb 12, 2024
@GabrielBFern GabrielBFern changed the title [mem_replace_with_default] No longer triggers on unused expression [mem_replace_with_default] No longer triggers on unused expression Feb 12, 2024
@Jarcho

Jarcho commented Feb 13, 2024

Copy link
Copy Markdown
Contributor

Thank you. @bors r+

@bors

bors commented Feb 13, 2024

Copy link
Copy Markdown
Contributor

📌 Commit 8355591 has been approved by Jarcho

It is now in the queue for this repository.

@bors

bors commented Feb 13, 2024

Copy link
Copy Markdown
Contributor

⌛ Testing commit 8355591 with merge 3e3a09e...

@bors

bors commented Feb 13, 2024

Copy link
Copy Markdown
Contributor

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Jarcho
Pushing 3e3a09e to master...

@bors
bors merged commit 3e3a09e into rust-lang:master Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mem::replace -> mem::take lint is too aggressive

4 participants