Skip to content
This repository was archived by the owner on Dec 29, 2022. It is now read-only.

Don't pass now removed MakeGlob parameter to rustc#1238

Merged
Xanewok merged 1 commit into
masterfrom
glob-map
Jan 18, 2019
Merged

Don't pass now removed MakeGlob parameter to rustc#1238
Xanewok merged 1 commit into
masterfrom
glob-map

Conversation

@Xanewok

@Xanewok Xanewok commented Jan 17, 2019

Copy link
Copy Markdown
Contributor

Needed for rust-lang/rust#57392 (Rust RLS submodule already points to this commit).

@emilyalbini

Copy link
Copy Markdown
Member

@bors are you still there?

@Xanewok

Xanewok commented Jan 17, 2019

Copy link
Copy Markdown
Contributor Author
thread 'rustc' panicked at 'assertion failed: analysis.glob_map.is_some()', src/librustc_save_analysis/lib.rs:1130:9

Looks like rust-lang/rust#57392 didn't get into newest nightly, will retry tomorrow.

@Xanewok

Xanewok commented Jan 18, 2019

Copy link
Copy Markdown
Contributor Author

Checked locally and it works; merging manually since we need specifically this commit.

@Xanewok Xanewok merged commit 1b3d687 into master Jan 18, 2019
@Xanewok Xanewok deleted the glob-map branch January 18, 2019 08:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants