Skip to content

Fix typo in fn variance#1716

Merged
nikomatsakis merged 1 commit into
rust-lang:masterfrom
aidanhs:aphs-fn-variance
Aug 18, 2016
Merged

Fix typo in fn variance#1716
nikomatsakis merged 1 commit into
rust-lang:masterfrom
aidanhs:aphs-fn-variance

Conversation

@aidanhs

@aidanhs aidanhs commented Aug 15, 2016

Copy link
Copy Markdown
Contributor

Per #738 (comment)

I'm a little unsure though since this hasn't been fixed for so long?

@eddyb

eddyb commented Aug 15, 2016

Copy link
Copy Markdown
Contributor

cc @rust-lang/lang

@nrc nrc added the T-lang Relevant to the language team, which will review and decide on the RFC. label Aug 16, 2016
@aidanhs

aidanhs commented Aug 17, 2016

Copy link
Copy Markdown
Contributor Author

Finally, there can be cases where it is ok to make a lifetime longer, but not shorter. This comes up when the lifetime is used in a function return type (and only a fn return type).

By the same line of thought, I think this is wrong as well and should refer to function arguments?

I.e. it is safe to treat a fn(&'a T) as a fn(&'static T)

@nikomatsakis

Copy link
Copy Markdown
Contributor

Looks like a correct typo.

@nikomatsakis nikomatsakis merged commit efb139d into rust-lang:master Aug 18, 2016
@nikomatsakis

Copy link
Copy Markdown
Contributor

Er, a correct fix =)

@aidanhs aidanhs deleted the aphs-fn-variance branch August 19, 2016 15:06
@Centril Centril added the not-rfc For PRs that fix things like spelling mistakes, wrong file names, etc. label Nov 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

not-rfc For PRs that fix things like spelling mistakes, wrong file names, etc. T-lang Relevant to the language team, which will review and decide on the RFC.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants