Bump byteorder and remove no-op feature#948
Merged
Merged
Conversation
RalfJung
reviewed
Sep 13, 2019
| directories = { version = "2.0", optional = true } | ||
| rustc_version = { version = "0.2.3", optional = true } | ||
| getrandom = { version = "0.1.8", features = ["std"] } | ||
| byteorder = "1.3" |
Member
There was a problem hiding this comment.
In terms of versions, isn't this a NOP? 1.3 is semver-compatible with 1.1.
Also it is possible that we had to add the feature to make sure we use the exact same feature as other projects in the rustc workspace. So I am not sure that we can just remove it here...
Member
|
Oh I see, the feature became a NOP with byteorder 1.3. That makes sense. |
Member
|
@bors r+ |
Contributor
|
📌 Commit 247ac22 has been approved by |
Contributor
bors
added a commit
that referenced
this pull request
Sep 13, 2019
Bump byteorder and remove no-op feature It's automatically detected: BurntSushi/byteorder@5b3ffee With this PR `byteorder` can be from [rustc-workspace-hack](https://github.com/rust-lang/rust/blob/f71826e8f26fd4fa331574caa462960db8ed961a/src/tools/rustc-workspace-hack/Cargo.toml#L74).
Contributor
|
☀️ Test successful - checks-travis, status-appveyor |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's automatically detected: BurntSushi/byteorder@5b3ffee
With this PR
byteordercan be from rustc-workspace-hack.